You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/07/26 19:01:59 UTC
Review Request 68067: Added flag to control GC-ing of nested container
sandboxes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Qian Zhang.
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description
-------
This adds an agent flag which enables garbage collection of finished
nested container sandboxes. Garbage collection follows the same
policy as the agent (as defined by --gc_delay and --gc_disk_headroom).
Diffs
-----
src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a
src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
Diff: https://reviews.apache.org/r/68067/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 68067: Added flag to control GC-ing of nested
container sandboxes.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On July 27, 2018, 9:37 a.m., Qian Zhang wrote:
> > I'd prefer to split this patch into two, one for adding the new flag and updating the related docs, and another for updating the containerizer's code.
The containerizer code changes have been moved into: https://reviews.apache.org/r/68095/
> On July 27, 2018, 9:37 a.m., Qian Zhang wrote:
> > src/slave/flags.hpp
> > Lines 92 (patched)
> > <https://reviews.apache.org/r/68067/diff/1/?file=2064443#file2064443line92>
> >
> > We also need to add this flag into `Http::STATE_HELP()` and a couple of docs, e.g., `agent.md`, `operator-http-api.md`, `sandbox.md`, `upgrade.md` and `CHANGELOG`.
Good idea. I've updated the review with changes to all those.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
-----------------------------------------------------------
On July 27, 2018, 5:22 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 5:22 p.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
>
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
>
>
> Diffs
> -----
>
> CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb
> docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7
> docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7
> docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13
> docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43
> src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe
> src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
> src/slave/http.cpp ab5864d9fd2fde478ed7da2ca7ed8abedc72c7c5
>
>
> Diff: https://reviews.apache.org/r/68067/diff/3/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68067: Added flag to control GC-ing of nested
container sandboxes.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
-----------------------------------------------------------
I'd prefer to split this patch into two, one for adding the new flag and updating the related docs, and another for updating the containerizer's code.
src/slave/flags.hpp
Lines 92 (patched)
<https://reviews.apache.org/r/68067/#comment289504>
We also need to add this flag into `Http::STATE_HELP()` and a couple of docs, e.g., `agent.md`, `operator-http-api.md`, `sandbox.md`, `upgrade.md` and `CHANGELOG`.
- Qian Zhang
On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
>
> (Updated July 27, 2018, 3:01 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes. Garbage collection follows the same
> policy as the agent (as defined by --gc_delay and --gc_disk_headroom).
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b
> src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a
> src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe
> src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
>
>
> Diff: https://reviews.apache.org/r/68067/diff/1/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68067: Added flag to control GC-ing of nested
container sandboxes.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review208236
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 23, 2018, 2:33 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 2:33 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
>
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
>
>
> Diffs
> -----
>
> CHANGELOG d423394cb883955690248ab0fbde2dc7a1c2fff0
> docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
> docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7
> docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13
> docs/upgrades.md dc61f9b92591bfd98352f1f50bfe7e2c48d3c9f4
> src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
> src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
> src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32
>
>
> Diff: https://reviews.apache.org/r/68067/diff/5/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68067: Added flag to control GC-ing of nested
container sandboxes.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/
-----------------------------------------------------------
(Updated Aug. 22, 2018, 11:33 a.m.)
Review request for mesos, Gilbert Song and Qian Zhang.
Changes
-------
Rebase + doc tweaks. The CHANGELOG change will probably need to be moved again (after the 1.7 release cut).
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description
-------
This adds an agent flag which enables garbage collection of finished
nested container sandboxes.
This also updates some documentation and recommends enabling this flag
when the user uses the same default executor to launch multiple tasks.
Diffs (updated)
-----
CHANGELOG 02e34664174c687f2094c01b8b07d4380678de5c
docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e
docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7
docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13
docs/upgrades.md ec9b3afa1dcba073815b5945aa9a1c32f64d43de
src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f
src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b
src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32
Diff: https://reviews.apache.org/r/68067/diff/4/
Changes: https://reviews.apache.org/r/68067/diff/3-4/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 68067: Added flag to control GC-ing of nested
container sandboxes.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206577
-----------------------------------------------------------
CHANGELOG
Lines 12 (patched)
<https://reviews.apache.org/r/68067/#comment289559>
s/Agent/agent/
CHANGELOG
Lines 13 (patched)
<https://reviews.apache.org/r/68067/#comment289560>
If we only garbage collect sandboxes created via the LAUNCH_NESTED_CONTAINER API, should we name this flag `--gc_nested_container_sandboxes`? Or we want this flag to cover standalone container in future?
docs/configuration/agent.md
Lines 892 (patched)
<https://reviews.apache.org/r/68067/#comment289566>
s/container/nested container/
docs/operator-http-api.md
Lines 3592 (patched)
<https://reviews.apache.org/r/68067/#comment289561>
s/Agent/agent/
docs/operator-http-api.md
Lines 3594-3595 (patched)
<https://reviews.apache.org/r/68067/#comment289565>
A newline between? Or we could merge these two paragraphs into one.
docs/operator-http-api.md
Lines 3595 (patched)
<https://reviews.apache.org/r/68067/#comment289563>
Besides this change, I think we also need to add this flag into the output of the agent API `GET_FLAGS` in this doc.
docs/operator-http-api.md
Lines 3596 (patched)
<https://reviews.apache.org/r/68067/#comment289562>
s/Agent/agent/
src/slave/flags.cpp
Lines 469 (patched)
<https://reviews.apache.org/r/68067/#comment289567>
Ditto.
- Qian Zhang
On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
>
> (Updated July 28, 2018, 8:22 a.m.)
>
>
> Review request for mesos, Gilbert Song and Qian Zhang.
>
>
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
>
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
>
>
> Diffs
> -----
>
> CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb
> docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7
> docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7
> docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13
> docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43
> src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe
> src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
> src/slave/http.cpp ab5864d9fd2fde478ed7da2ca7ed8abedc72c7c5
>
>
> Diff: https://reviews.apache.org/r/68067/diff/3/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 68067: Added flag to control GC-ing of nested
container sandboxes.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/
-----------------------------------------------------------
(Updated July 27, 2018, 5:22 p.m.)
Review request for mesos, Gilbert Song and Qian Zhang.
Changes
-------
Changed this review to be mostly documentation.
Bugs: MESOS-7947
https://issues.apache.org/jira/browse/MESOS-7947
Repository: mesos
Description (updated)
-------
This adds an agent flag which enables garbage collection of finished
nested container sandboxes.
This also updates some documentation and recommends enabling this flag
when the user uses the same default executor to launch multiple tasks.
Diffs (updated)
-----
CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb
docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7
docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7
docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13
docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43
src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe
src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478
Diff: https://reviews.apache.org/r/68067/diff/2/
Changes: https://reviews.apache.org/r/68067/diff/1-2/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu