You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sunng87 (via GitHub)" <gi...@apache.org> on 2023/03/16 15:11:13 UTC

[GitHub] [arrow-rs] sunng87 opened a new issue, #3876: Pinned version in arrow-flight's build-dependencies are causing conflicts

sunng87 opened a new issue, #3876:
URL: https://github.com/apache/arrow-rs/issues/3876

   **Describe the bug**
   
   When we add arrow-flight as a dependency to a project that already has `prost-build` as a build-dependency, there is a big chance that cargo will fail to select a valid version of `prost-build` and it cause build failure. The reason is we are using pinned versions of `prost-build`. When the project has a newer patch version for `prost-build`, for example, updated by dependabot, the pinned version will conflict with project's requirement for `prost-build`. 
   
   **To Reproduce**
   
   This happens to any project that:
   
   - has `prost-build` as build-dependency, with version "0.11.8"
   - adds `arrow-flight` 35 as dependency, which pins `prost-build` to "0.11.7"
   - cargo build: conflict.
   
   **Possible solutions**
   
   There are some proposals to consider:
   
   - simply relax the pin
   - don't check in generated sources
   - use pinned prost-build as dev-dependency and generate the code via script or ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on issue #3876: Pinned version in arrow-flight's build-dependencies are causing conflicts

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on issue #3876:
URL: https://github.com/apache/arrow-rs/issues/3876#issuecomment-1472304171

   Some context on this - https://github.com/apache/arrow-rs/issues/2616
   
   > use pinned prost-build as dev-dependency and generate the code via script or ci
   
   I would be happy to review a PR that does this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold closed issue #3876: Pinned version in arrow-flight's build-dependencies are causing conflicts

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold closed issue #3876: Pinned version in arrow-flight's build-dependencies are causing conflicts
URL: https://github.com/apache/arrow-rs/issues/3876


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] sunng87 commented on issue #3876: Pinned version in arrow-flight's build-dependencies are causing conflicts

Posted by "sunng87 (via GitHub)" <gi...@apache.org>.
sunng87 commented on issue #3876:
URL: https://github.com/apache/arrow-rs/issues/3876#issuecomment-1482314667

   @tustvold I just created a PR following a good practice from stackoverflow: #3926 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org