You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by ah...@apache.org on 2017/03/31 06:27:54 UTC
zeppelin git commit: [HOTFIX][gh-pages] Fix Maven web link for
INTERPRETER type pkg
Repository: zeppelin
Updated Branches:
refs/heads/gh-pages 6e5d572e0 -> abbf75c07
[HOTFIX][gh-pages] Fix Maven web link for INTERPRETER type pkg
### What is this PR for?
In current https://zeppelin.apache.org/helium_packages.html page, `INTERPRETER` type package web link is wrong. It should point Maven web link not npm. So I fixed it.
### What type of PR is it?
Hot Fix
### What is the Jira issue?
N/A
### How should this be tested?
Run the website(`gh-pages`) locally as described in [here](https://github.com/apache/zeppelin/tree/gh-pages#run-website) and click any `INTERPRETER` type of package name.
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fb...@hanmail.net>
Closes #2208 from AhyoungRyu/fix/mavenLink and squashes the following commits:
9fdb50b [AhyoungRyu] Fix maven serach link for INTERPRETER type pkg
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/abbf75c0
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/abbf75c0
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/abbf75c0
Branch: refs/heads/gh-pages
Commit: abbf75c071272e35dacd8c3bee73cfadd892e275
Parents: 6e5d572
Author: AhyoungRyu <fb...@hanmail.net>
Authored: Fri Mar 31 11:37:11 2017 +0900
Committer: ahyoungryu <ah...@apache.org>
Committed: Fri Mar 31 15:27:47 2017 +0900
----------------------------------------------------------------------
assets/themes/zeppelin/js/helium.controller.js | 1 -
helium_packages.md | 16 ++++++++++++++--
2 files changed, 14 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/abbf75c0/assets/themes/zeppelin/js/helium.controller.js
----------------------------------------------------------------------
diff --git a/assets/themes/zeppelin/js/helium.controller.js b/assets/themes/zeppelin/js/helium.controller.js
index 8d97292..a6ea5ee 100644
--- a/assets/themes/zeppelin/js/helium.controller.js
+++ b/assets/themes/zeppelin/js/helium.controller.js
@@ -2,7 +2,6 @@ angular.module("app", ['ui.bootstrap'])
.controller("HeliumPkgCtrl", function($rootScope, $scope, $window, $sce) {
$rootScope.keys = Object.keys
$scope.HeliumPkgs = zeppelinHeliumPackages
- $scope.npmWebLink = 'https://www.npmjs.com/package'
$scope.intpDefaultIcon = $sce.trustAsHtml('<img src="assets/themes/zeppelin/img/maven_default_icon.png" style="width: 12px"/>');
$scope.latestPkgInfo = {}
$scope.allTypePkgs = {}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/abbf75c0/helium_packages.md
----------------------------------------------------------------------
diff --git a/helium_packages.md b/helium_packages.md
index 314df8c..4792a37 100644
--- a/helium_packages.md
+++ b/helium_packages.md
@@ -70,7 +70,13 @@ and [What is Apache Zeppelin Spell](https://zeppelin.apache.org/docs/snapshot/de
ng-if="pkg.type === 'INTERPRETER'"
ng-bind-html="intpDefaultIcon"></div>
<div class="heliumPackageName">
- <a ng-href="{% raw %}{{npmWebLink}}/{{pkg.name}}{% endraw %}"
+ <a ng-if="pkg.type !== 'INTERPRETER'"
+ ng-href="https://www.npmjs.com/package/{% raw %}{{pkg.name}}{% endraw %}"
+ target="_blank">
+ {% raw %}{{pkg.name}}{% endraw %}
+ </a>
+ <a ng-if="pkg.type === 'INTERPRETER'"
+ ng-href="http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22{% raw %}{{pkg.artifactId}}{% endraw %}%22%20AND%20v%3A%22{% raw %}{{pkg.version}}{% endraw %}%22"
target="_blank">
{% raw %}{{pkg.name}}{% endraw %}
</a>
@@ -108,7 +114,13 @@ and [What is Apache Zeppelin Spell](https://zeppelin.apache.org/docs/snapshot/de
ng-if="pkg.type === 'INTERPRETER'"
ng-bind-html="intpDefaultIcon"></div>
<div class="heliumPackageName">
- <a ng-href="{% raw %}{{npmWebLink}}/{{pkg.name}}{% endraw %}"
+ <a ng-if="pkg.type !== 'INTERPRETER'"
+ ng-href="https://www.npmjs.com/package/{% raw %}{{pkg.name}}{% endraw %}"
+ target="_blank">
+ {% raw %}{{pkg.name}}{% endraw %}
+ </a>
+ <a ng-if="pkg.type === 'INTERPRETER'"
+ ng-href="http://search.maven.org/#search%7Cga%7C1%7Ca%3A%22{% raw %}{{pkg.artifactId}}{% endraw %}%22%20AND%20v%3A%22{% raw %}{{pkg.version}}{% endraw %}%22"
target="_blank">
{% raw %}{{pkg.name}}{% endraw %}
</a>