You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2016/03/02 19:38:18 UTC
[jira] [Commented] (PHOENIX-2733) Minor cleanup for improvements to
CSV Bulk Loader performance
[ https://issues.apache.org/jira/browse/PHOENIX-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176205#comment-15176205 ]
James Taylor commented on PHOENIX-2733:
---------------------------------------
I filed this on [~gabriel.reid]'s behalf. Do you think you can get to this cleaned up before we cut an RC, [~sergey.soldatov]?
> Minor cleanup for improvements to CSV Bulk Loader performance
> -------------------------------------------------------------
>
> Key: PHOENIX-2733
> URL: https://issues.apache.org/jira/browse/PHOENIX-2733
> Project: Phoenix
> Issue Type: Bug
> Reporter: Gabriel Reid
> Assignee: Sergey Soldatov
> Priority: Minor
> Fix For: 4.8.0
>
>
> Based on the improvements from PHOENIX-1973, there are a few small things that could use some touching up:
> * TargetTableRefFunctions#LOGICAN_NAMES_TO_JSON appears to be spelled incorrectly (should be LOGICAL_NAMES_TO_JSON), and I don’t understand why it’s a Function instead of just a static method (it matches other Functions in that class, but the general use of Functions in that way makes no sense)
> * FormatToKeyValueMapper should probably be renamed to accurately describe what it does, as well as definitely updating the class-level javadoc to explain what it does (i.e. it’s not creating KeyValues any more)
> * Pretty minor code format issues, such as lack of correct spacing in FormatToKeyValueMapper#findIndex and elsewhere, and the use of wildcard imports in FormatToKeyValueMapper
> * Minor nit, but why is TrustedByteArrayOutputStream being used in FormatToKeyValueMapper#writeAggregatedRow?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)