You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "zahash (via GitHub)" <gi...@apache.org> on 2024/03/21 12:21:19 UTC

[PR] Fix test db temp file path [incubator-answer]

zahash opened a new pull request, #871:
URL: https://github.com/apache/incubator-answer/pull/871

   there should be a slash between temp dir and the db name; instead of creating a database at /tmp/answer-test-data.db it instead t
   ries to create /tmpanswer-test-data.db; which is not correct


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix test db temp file path [incubator-answer]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #871:
URL: https://github.com/apache/incubator-answer/pull/871#issuecomment-2014266733

   @zahash Thanks for your contributions. LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix test db temp file path [incubator-answer]

Posted by "surapuramakhil (via GitHub)" <gi...@apache.org>.
surapuramakhil commented on PR #871:
URL: https://github.com/apache/incubator-answer/pull/871#issuecomment-2012142135

   @zahash  these test cases were created for container environment. It's not a bug, it's actually enhancement.
   
   Make sure your changes work for other Envs like docker and k8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix test db temp file path [incubator-answer]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars merged PR #871:
URL: https://github.com/apache/incubator-answer/pull/871


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org