You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "okiyuki99 (via GitHub)" <gi...@apache.org> on 2026/10/20 08:36:06 UTC

[PR] feat(microsoft): import Power BI projects saved as split TMDL [ossie]

okiyuki99 opened a new pull request, #620:
URL: https://github.com/apache/ossie/pull/620

   ## Summary
   
   ### Why
   
   Power BI projects saved as split TMDL cannot currently be imported directly. Users need to export or reconstruct a standalone model document before converting a project stored in Git.
   
   ### What
   
   - Accept a `.pbip` file, a semantic model folder containing `definition/`, or the `definition` folder itself through the CLI and the new `import_powerbi_project` library function.
   - Resolve `.pbip` input through the report's `definition.pbir` and `datasetReference.byPath`.
   - Load TMDL documents with their relative paths through the existing optional TOM integration, then reuse the TMSL-to-Ossie mapping.
   - Report invalid project metadata and TOM loading errors through the CLI, document the supported inputs and `--strict` limits, and add unit and offline TOM integration coverage.
   
   ```bash
   ossie-microsoft import -i Sales.pbip -o model.yaml
   ossie-microsoft import -i Sales.SemanticModel -o model.yaml
   ossie-microsoft import -i Sales.SemanticModel/definition -o model.yaml
   ```
   
   The project import path supports local split-TMDL models. Remote `byConnection` models and projects saved as TMSL are outside this path. Standalone `model.bim` import remains independent of TOM. No dependencies or specification changes are introduced.
   
   ## Review points
   
   - Project resolution and forwarding of split documents to TOM, including table files whose names start with a dot.
   - Preservation of table order, fields, metrics, relationships, and vendor metadata across the split-TMDL import.
   - TOM continues to ignore missing `ref` targets; the README and an integration test document that `--strict` does not check project completeness or DAX validity.
   
   ## Validation
   
   Validated on macOS arm64 against main at `8551d85`:
   
   | Environment | Result |
   | --- | --- |
   | Python 3.12.12, TOM 19.114.8, .NET 8.0.32 | 479 passed; coverage 95.90% |
   | Python 3.10.21, without the TOM extra | 468 passed, 1 optional integration module skipped; coverage 95.90% |
   | Python 3.14.7, without the TOM extra | 468 passed, 1 optional integration module skipped; coverage 95.89% |
   
   - `ruff check .` passed.
   - Apache RAT 0.17 passed on a clean snapshot of main plus the submitted changes.
   - The installed CLI imported all three project input forms, and each output passed the repository validator.
   - The installed CLI completed the existing BIM import/export round trip; the YAML passed the repository validator and the exported BIM passed offline TOM validation.
   - `git diff --check` passed.
   
   Linux GitHub Actions checks remain to be confirmed on this PR.
   
   ## Related Issues
   
   Closes #541
   
   ## Checklist
   
   ### Documentation
   
   - [x] Updated the converter README with input examples, optional TOM setup, the Python API, and validation limits.
   
   ### Tests
   
   - [x] Existing converter tests pass locally.
   - [x] New functionality is covered by unit and offline TOM integration tests.
   - [ ] GitHub Actions checks pass.
   
   ### Compliance
   
   - [x] New Python source files include ASF license headers; the project data fixture is explicitly excluded from RAT checks.
   - [x] No new third-party dependencies or vendored source code.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(microsoft): import Power BI projects saved as split TMDL [ossie]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #620:
URL: https://github.com/apache/ossie/pull/620#issuecomment-6314077114

   @okiyuki99 as shared on the dev mailing list, the converters have moved to a new dedicated repository: https://github.com/apache/ossie-converters
   
   Do you mind to create the PR on the new repo? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat(microsoft): import Power BI projects saved as split TMDL [ossie]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre closed pull request #620: feat(microsoft): import Power BI projects saved as split TMDL
URL: https://github.com/apache/ossie/pull/620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org