You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/06/26 22:30:02 UTC

[GitHub] [couchdb-helm] borigas opened a new pull request #34: Add default values for annotations

borigas opened a new pull request #34:
URL: https://github.com/apache/couchdb-helm/pull/34


   <!--
   Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
   make sure you are aware of the chart technical requirements and best practices:
   
   * https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
   * https://github.com/helm/helm/tree/master/docs/chart_best_practices
   
   For a quick overview across what we will look at reviewing your PR, please read
   our review guidelines:
   
   * https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
   
   Following our best practices right from the start will accelerate the review process and
   help get your PR merged quicker.
   
   When updates to your PR are requested, please add new commits and do not squash the
   history. This will make it easier to identify new changes. The PR will be squashed
   anyways when it is merged. Thanks.
   
   Please make sure you test your changes before you push them.
   -->
   
   #### What this PR does / why we need it:
   Values with their children commented out were getting their types changed causing warnings during install.
   
   #### Which issue this PR fixes
   *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
     - fixes #32
   
   #### Special notes for your reviewer:
   
   #### Checklist
   [Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
   - [x] Chart Version bumped
   - [x] e2e tests pass
   - [x] Variables are documented in the README.md
   - [x] Chart tgz added to /docs and index updated
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] willholley merged pull request #34: Add default values for annotations

Posted by GitBox <gi...@apache.org>.
willholley merged pull request #34:
URL: https://github.com/apache/couchdb-helm/pull/34


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb-helm] willholley commented on pull request #34: Add default values for annotations

Posted by GitBox <gi...@apache.org>.
willholley commented on pull request #34:
URL: https://github.com/apache/couchdb-helm/pull/34#issuecomment-650526796


   thanks for the PR / fix @borigas!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org