Re:[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #491: ServiceDiscoveryRegistry implementation

[Brooks <br...@chtrak.com>]

如何退订












If you have great talents, industry will improve them; if you have but moderate abilities, industry will supply their deficiency
If you have further question, please don't hesitate to contact us again.
Have a nice day :)


Best regards,
Brooks






----------------------------------------------------------------- 
This message may contain confidential information. If you are
not the intended recipient and have received this message, please
notify the sender and delete it from the system immediately.
Disclosing, duplicating this message or taking action based on it,
is strictly prohibited. 
-----------------------------------------------------------------









在2020年04月29 10时29分，"GitBox"<gi...@apache.org>写道：

AlexStocks commented on a change in pull request #491:
URL: https://github.com/apache/dubbo-go/pull/491#discussion_r417033848



##########
File path: go.mod
##########
@@ -23,6 +23,7 @@ require (
 	github.com/golang/mock v1.3.1
 	github.com/golang/protobuf v1.3.2
 	github.com/google/btree v1.0.0 // indirect
+	github.com/gotestyourself/gotestyourself v2.2.0+incompatible

Review comment:
       why import this useless package?

##########
File path: common/extension/service_instance_selector_factory.go
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package extension
+
+import (
+	"github.com/apache/dubbo-go/registry/service/instance"

Review comment:
       pls do not place the dubbo-go package and the third package in the same import block.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org