You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/06 11:36:20 UTC
[GitHub] [pulsar] XComp opened a new issue, #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
XComp opened a new issue, #17949:
URL: https://github.com/apache/pulsar/issues/17949
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### Version
2.10.0
### Minimal reproduce step
`org.apache.pulsar:pulsar-client-all:2.10.0` provides a kind of empty NOTICE file:
```
$ unzip -p ~/.m2/repository/org/apache/pulsar/pulsar-client-all/2.10.0/pulsar-client-all-2.10.0.jar META-INF/NOTICE
Pulsar Client All
Copyright 2017-2020 Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
$
```
### What did you expect to see?
I would expect shaded dependencies (see [apache/pulsar:pulsar-client-all/pom.xml:L120](https://github.com/apache/pulsar/blob/master/pulsar-client-all/pom.xml#L120)) being mentioned in the NOTICE file.
### What did you see instead?
NOTICE file being empty
### Anything else?
_No response_
### Are you willing to submit a PR?
- [ ] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17949:
URL: https://github.com/apache/pulsar/issues/17949#issuecomment-1339408235
Closed. Apache license doesn't enforce the root `NOTICE` file to contain all the NOTICE content from dependencies, but only if we convey the NOTICEs content from dependencies in _some_ way: you can read them at `META-INF/NOTICE.md` or `META-INF/NOTICE.markdown`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #17949:
URL: https://github.com/apache/pulsar/issues/17949#issuecomment-1275560641
@lhotari @nicoloboschi - are either of you familiar with this part of the artifact generation? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #17949:
URL: https://github.com/apache/pulsar/issues/17949#issuecomment-1312319160
The issue had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17949:
URL: https://github.com/apache/pulsar/issues/17949#issuecomment-1339411071
Above the copyright year issue, it seems about build time. @michaeljmarshall IIRC you submitted a patch to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun closed issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
URL: https://github.com/apache/pulsar/issues/17949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on issue #17949: [Bug] There's no proper NOTICE file provided for pulsar-client-all
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #17949:
URL: https://github.com/apache/pulsar/issues/17949#issuecomment-1275561756
I can confirm the same results for a recent build of master branch:
```
$ unzip -p /Users/michaelmarshall/.m2/repository/org/apache/pulsar/pulsar-client-all/2.11.0-SNAPSHOT/pulsar-client-all-2.11.0-SNAPSHOT.jar META-INF/NOTICE
Pulsar Client All
Copyright 2017-2020 Apache Software Foundation
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
```
The copyright dates even look wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org