You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2011/03/02 19:30:37 UTC

[jira] Created: (THRIFT-1080) erlang test's 'make' fails on Mac OSX

erlang test's 'make' fails on Mac OSX
-------------------------------------

                 Key: THRIFT-1080
                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
             Project: Thrift
          Issue Type: Bug
            Reporter: Bryan Duxbury
            Priority: Minor


{code}
[bryanduxbury erl]$make
rm -rf gen
../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
../../compiler/cpp/thrift --gen erl ../StressTest.thrift
mkdir -p gen/include
mkdir -p gen/src
mkdir -p gen/ebin
mv -t gen/include gen-erl/*.hrl
mv: illegal option -- t
usage: mv [-f | -i | -n] [-v] source target
       mv [-f | -i | -n] [-v] source ... directory
make: *** [gen] Error 64

{code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010480#comment-13010480 ] 

Bryan Duxbury commented on THRIFT-1080:
---------------------------------------

Your patch is definitely an improvement, but:

{code}
[bryanduxbury erl]$make
mkdir -p ebin
erlc  -Igen/include -Iinclude -I../../lib/erl/include -o ebin src/test_server.erl
src/test_server.erl:144: undefined macro 'thriftTest_EIGHT'
src/test_server.erl:22: function handle_function/2 undefined
make: *** [ebin/test_server.beam] Error 1
{code}

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010775#comment-13010775 ] 

Hudson commented on THRIFT-1080:
--------------------------------

Integrated in Thrift #100 (See [https://hudson.apache.org/hudson/job/Thrift/100/])
    THRIFT-1080 : fix building of test code


> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Assignee: Anthony Molinaro
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell updated THRIFT-1080:
---------------------------------

    Attachment: thrift-1080.patch

changes the move call in erlang test case to use mv SOURCE DEST rather than specifying a target

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010677#comment-13010677 ] 

Jake Farrell commented on THRIFT-1080:
--------------------------------------

My patch will fix the build issue, but there is a problem with the erlang test code. The test cases look like they are missing a file. None of the tests in the src folder can compile due to the missing thriftTest_# macros and these macros are no where to be found in the source.

Anthony, Chris, Todd, can one of you take a look at this

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Molinaro resolved THRIFT-1080.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
         Assignee: Anthony Molinaro

Merged in patch plus a few changes required to have these compile.

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Assignee: Anthony Molinaro
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010759#comment-13010759 ] 

Anthony Molinaro commented on THRIFT-1080:
------------------------------------------

The way enumerations were generated changed at some point, but the test code was not up to date.  I fixed the compile issues and commited the changes along with your patch.

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Priority: Minor
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury updated THRIFT-1080:
----------------------------------

    Component/s: Erlang - Library

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Priority: Minor
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010761#comment-13010761 ] 

Anthony Molinaro commented on THRIFT-1080:
------------------------------------------

I just realized why this bug felt so familiar, I fixed the exact same problems in the tutorial directory a month or so ago :)

I did a few finds and don't see any more examples of the use of mv -t.

> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Assignee: Anthony Molinaro
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1080) erlang test's 'make' fails on Mac OSX

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1080.
---------------------------------


> erlang test's 'make' fails on Mac OSX
> -------------------------------------
>
>                 Key: THRIFT-1080
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1080
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Bryan Duxbury
>            Assignee: Anthony Molinaro
>            Priority: Minor
>             Fix For: 0.7
>
>         Attachments: thrift-1080.patch
>
>
> {code}
> [bryanduxbury erl]$make
> rm -rf gen
> ../../compiler/cpp/thrift --gen erl ../ThriftTest.thrift
> ../../compiler/cpp/thrift --gen erl ../StressTest.thrift
> mkdir -p gen/include
> mkdir -p gen/src
> mkdir -p gen/ebin
> mv -t gen/include gen-erl/*.hrl
> mv: illegal option -- t
> usage: mv [-f | -i | -n] [-v] source target
>        mv [-f | -i | -n] [-v] source ... directory
> make: *** [gen] Error 64
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira