You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/02 18:57:25 UTC

[GitHub] [hadoop-ozone] hanishakoneru opened a new pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException

hanishakoneru opened a new pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException
URL: https://github.com/apache/hadoop-ozone/pull/760
 
 
   ## What changes were proposed in this pull request?
   
   On receiving NotLeaderException from OM server, we should failover to the next OM in the list instead of the suggested Leader. This will ensure that all the OMs are contacted in a round robin way. Failing always to the suggested leader is not robust.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3334
   
   ## How was this patch tested?
   
   TestOzoneManagerHA#testOMProxyProviderFailoverToCurrentLeader already covers this test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru commented on a change in pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException

Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on a change in pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException
URL: https://github.com/apache/hadoop-ozone/pull/760#discussion_r402549446
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
 ##########
 @@ -726,7 +726,7 @@ public void testOMProxyProviderFailoverToCurrentLeader() throws Exception {
     // information must be returned via the response and a failover must
     // happen to the leader proxy node.
     createVolumeTest(true);
-    Thread.sleep(2000);
+    Thread.sleep(5000);
 
 Review comment:
   Didn't realize till Bharat pointed out that this test is disabled. I ll revert the change to test and we can fix this when enabling TestOzoneManagerHA. That test was disabled as it was flaky and would need more work before it can be enabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on issue #760: HDDS-3334. OM Client failover to next OM on NotLeaderException

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #760: HDDS-3334. OM Client failover to next OM on NotLeaderException
URL: https://github.com/apache/hadoop-ozone/pull/760#issuecomment-608053657
 
 
   +1 LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru merged pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException

Posted by GitBox <gi...@apache.org>.
hanishakoneru merged pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException
URL: https://github.com/apache/hadoop-ozone/pull/760
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException
URL: https://github.com/apache/hadoop-ozone/pull/760#discussion_r402552708
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
 ##########
 @@ -726,7 +726,7 @@ public void testOMProxyProviderFailoverToCurrentLeader() throws Exception {
     // information must be returned via the response and a failover must
     // happen to the leader proxy node.
     createVolumeTest(true);
-    Thread.sleep(2000);
+    Thread.sleep(5000);
 
 Review comment:
   Sounds good!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException

Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #760: HDDS-3334. OM Client failover to next OM on NotLeaderException
URL: https://github.com/apache/hadoop-ozone/pull/760#discussion_r402546061
 
 

 ##########
 File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
 ##########
 @@ -726,7 +726,7 @@ public void testOMProxyProviderFailoverToCurrentLeader() throws Exception {
     // information must be returned via the response and a failover must
     // happen to the leader proxy node.
     createVolumeTest(true);
-    Thread.sleep(2000);
+    Thread.sleep(5000);
 
 Review comment:
   Can we use lambdaTestUtils instead of sleep?
   ```suggestion
       LambdaTestUtils.await(6000, 2000, () -> (omFailoverProxyProvider.getCurrentProxyOMNodeId().equals(leaderOMNodeId)));
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org