(superset) 01/01: test(warm_up_cache): pin native filter defaults dropped from cache warming

[ru...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rusackas pushed a commit to branch tdd/warmup-cache-native-filter-order-42382
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 1e37e79b6173fb2c8964b3323de827dd1f4a855d
Author: rusackas <ev...@rusackas.com>
AuthorDate: Mon Aug 10 15:14:39 2026 -0700

    test(warm_up_cache): pin native filter defaults dropped from cache warming
    
    get_dashboard_extra_filters() in superset/views/utils.py only reads the
    legacy Filter Box default_filters/filter_scopes metadata; it never looks
    at native_filter_configuration. ChartWarmUpCacheCommand relies on this
    function to reconstruct a dashboard's applied filters for cache warming,
    so for any dashboard built with native filters (the standard mechanism
    today, not the deprecated Filter Box) warming silently applies none of
    the dashboard's actual default filters -- the warmed cache key never
    matches what the browser requests, and warm_up_cache is effectively a
    no-op for such dashboards.
    
    A correct native-filter extractor already exists and is wired into the
    real /api/v1/chart/data endpoint
    (superset.charts.data.dashboard_filter_context.get_dashboard_filter_context
    / apply_dashboard_filter_context, see superset/charts/data/api.py) --
    ChartWarmUpCacheCommand just isn't using it. That's the natural fix to
    reach for, but this PR is test-only: it pins the reproduction so the fix
    can be reviewed and merged separately with the failing test as its
    acceptance criterion.
    
    Verified independently against current master (both the missing
    native-filter read and the affected code paths), not just the original
    report.
    
    Fixes #43024
---
 tests/unit_tests/views/test_utils.py | 82 +++++++++++++++++++++++++++++++++++-
 1 file changed, 81 insertions(+), 1 deletion(-)

diff --git a/tests/unit_tests/views/test_utils.py b/tests/unit_tests/views/test_utils.py
index 8da8ebf21f5..25d12073a92 100644
--- a/tests/unit_tests/views/test_utils.py
+++ b/tests/unit_tests/views/test_utils.py
@@ -17,8 +17,14 @@
 """Tests for superset.views.utils module"""
 
 from flask import current_app
+from sqlalchemy.orm.session import Session
 
-from superset.views.utils import get_form_data
+from superset import db
+from superset.connectors.sqla.models import Database, SqlaTable
+from superset.models.dashboard import Dashboard
+from superset.models.slice import Slice
+from superset.utils import json
+from superset.views.utils import get_dashboard_extra_filters, get_form_data
 
 
 def test_get_form_data_handles_non_json_body_with_json_content_type() -> None:
@@ -51,3 +57,77 @@ def test_get_form_data_handles_non_dict_json_body() -> None:
 
     assert form_data == {}
     assert slc is None
+
+
+def test_get_dashboard_extra_filters_ignores_native_filter_defaults(
+    session: Session,
+) -> None:
+    """
+    get_dashboard_extra_filters must surface native filter defaults, not just
+    the legacy Filter Box ``default_filters``/``filter_scopes`` metadata.
+
+    Reported in apache/superset#43024 (originally raised in discussion #42382):
+    ``ChartWarmUpCacheCommand`` relies on this function to reconstruct a
+    dashboard's applied filters for cache warming. Because it only reads the
+    legacy fields, warming a
+    dashboard that uses native filters (the standard mechanism today, not the
+    deprecated Filter Box) silently drops every native filter's default
+    value, so the warmed cache key never matches what the browser actually
+    requests and warm_up_cache is effectively a no-op for such dashboards.
+
+    A working native-filter extractor already exists and is wired into the
+    real ``/api/v1/chart/data`` endpoint (see
+    ``superset.charts.data.dashboard_filter_context.get_dashboard_filter_context``)
+    -- this function just isn't using it.
+    """
+    Dashboard.metadata.create_all(session.get_bind())
+
+    dataset = SqlaTable(
+        table_name="extra_filters_table",
+        database=Database(database_name="extra_filters_db", sqlalchemy_uri="sqlite://"),
+    )
+    db.session.add(dataset)
+    db.session.flush()
+
+    chart = Slice(
+        slice_name="chart_with_native_filter",
+        datasource_id=dataset.id,
+        datasource_type="table",
+    )
+
+    native_filter_configuration = [
+        {
+            "id": "NATIVE_FILTER-1",
+            "name": "Region filter",
+            "type": "NATIVE_FILTER",
+            "scope": {"rootPath": ["ROOT_ID"], "excluded": []},
+            "targets": [{"column": {"name": "region"}}],
+            "defaultDataMask": {
+                "extraFormData": {
+                    "filters": [{"col": "region", "op": "IN", "val": ["APAC"]}]
+                },
+                "filterState": {"value": ["APAC"]},
+            },
+            "controlValues": {},
+        }
+    ]
+    dashboard = Dashboard(
+        dashboard_title="native_filter_dash",
+        slices=[chart],
+        published=True,
+        json_metadata=json.dumps(
+            {"native_filter_configuration": native_filter_configuration}
+        ),
+        position_json="{}",
+    )
+    db.session.add_all([chart, dashboard])
+    db.session.flush()
+
+    extra_filters = get_dashboard_extra_filters(chart.id, dashboard.id)
+
+    assert extra_filters, (
+        "get_dashboard_extra_filters returned no filters for a dashboard "
+        "with a native filter default value -- it currently only reads the "
+        "legacy default_filters/filter_scopes metadata, so native filter "
+        "defaults are silently dropped from cache warming."
+    )