[GitHub] [pulsar] shibd commented on a diff in pull request #16279: [refactor][function][PIP-166] Function add MANUAL delivery semantics

[GitBox <gi...@apache.org>]

shibd commented on code in PR #16279:
URL: https://github.com/apache/pulsar/pull/16279#discussion_r912786081


##########
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java:
##########
@@ -350,7 +351,8 @@ private StateStoreProvider getStateStoreProvider() throws Exception {
         }
     }
 
-    private void handleResult(Record srcRecord, JavaExecutionResult result) throws Exception {
+    @VisibleForTesting
+    protected void handleResult(Record srcRecord, JavaExecutionResult result) throws Exception {

Review Comment:
   I need to test it, so change to protected and add @VisibleForTesting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org