You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/10/23 02:40:12 UTC
[jira] [Created] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Avery Ching created GIRAPH-384:
----------------------------------
Summary: Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Key: GIRAPH-384
URL: https://issues.apache.org/jira/browse/GIRAPH-384
Project: Giraph
Issue Type: Bug
Reporter: Avery Ching
Assignee: Avery Ching
We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482043#comment-13482043 ]
Nitay Joffe commented on GIRAPH-384:
------------------------------------
Oh whoops I see thought it was committed already. My bad, commented on review.
> Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
> ------------------------------------------------------------------------------------------
>
> Key: GIRAPH-384
> URL: https://issues.apache.org/jira/browse/GIRAPH-384
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-384.patch
>
>
> We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482039#comment-13482039 ]
Nitay Joffe commented on GIRAPH-384:
------------------------------------
Sweet! Minor nit: you should put jar versions in top level pom.xml, and you can use ${project.version} instead of 0.2-SNAPSHOT as we want those two tied to each other. If you look I did same thing with giraph dependency itself.
> Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
> ------------------------------------------------------------------------------------------
>
> Key: GIRAPH-384
> URL: https://issues.apache.org/jira/browse/GIRAPH-384
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-384.patch
>
>
> We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-384:
-------------------------------
Attachment: GIRAPH-384.patch
Patch available:
Passes mvn clean install
https://reviews.apache.org/r/7702/
> Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
> ------------------------------------------------------------------------------------------
>
> Key: GIRAPH-384
> URL: https://issues.apache.org/jira/browse/GIRAPH-384
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-384.patch
>
>
> We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482053#comment-13482053 ]
Hudson commented on GIRAPH-384:
-------------------------------
Integrated in Giraph-trunk-Commit #250 (See [https://builds.apache.org/job/Giraph-trunk-Commit/250/])
GIRAPH-384: Remove duplicate BspCase in giraph-formats-contrib (and
fix GIRAPH-382 breaking the build). (aching) (Revision 1401137)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1401137
Files :
* /giraph/trunk/CHANGELOG
* /giraph/trunk/giraph-formats-contrib/pom.xml
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/BspCase.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/accumulo/TestAccumuloVertexFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hbase/TestHBaseRootMarkerVertextFormat.java
* /giraph/trunk/giraph-formats-contrib/src/test/java/org/apache/giraph/io/hcatalog/TestHiveUtils.java
> Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
> ------------------------------------------------------------------------------------------
>
> Key: GIRAPH-384
> URL: https://issues.apache.org/jira/browse/GIRAPH-384
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-384.patch
>
>
> We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482008#comment-13482008 ]
Alessandro Presta commented on GIRAPH-384:
------------------------------------------
One less hack in our codebase, easy +1!
> Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
> ------------------------------------------------------------------------------------------
>
> Key: GIRAPH-384
> URL: https://issues.apache.org/jira/browse/GIRAPH-384
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-384.patch
>
>
> We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-384) Remove duplicate BspCase in
giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482011#comment-13482011 ]
Avery Ching commented on GIRAPH-384:
------------------------------------
Thanks for the quick review, committed. Sorry about the break of the build earlier, argh.
> Remove duplicate BspCase in giraph-formats-contrib (and fix GIRAPH-382 breaking the build)
> ------------------------------------------------------------------------------------------
>
> Key: GIRAPH-384
> URL: https://issues.apache.org/jira/browse/GIRAPH-384
> Project: Giraph
> Issue Type: Bug
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-384.patch
>
>
> We should use the tests jar instead of duplicating BspCase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira