You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/05/29 17:01:13 UTC

[GitHub] [druid] gianm commented on pull request #9944: exception in transformAsync may cause future to never complete

gianm commented on pull request #9944:
URL: https://github.com/apache/druid/pull/9944#issuecomment-636080313


   > ok, unless people feel strongly about adding a test for this, I'm going to merge this then.
   
   IMO it'd be good to copy the tests too from Guava (if they would cover this), because if we decide to change this later, it'd be good to have the tests. Also, it'd help us validate future JDK upgrades etc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org