You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/04 17:09:45 UTC
[GitHub] [beam] ayushthe1 opened a new pull request, #23984: [Task]: Standardize `typehint` in Python documention and docstrings
ayushthe1 opened a new pull request, #23984:
URL: https://github.com/apache/beam/pull/23984
fixes #23950
Currently 3 different formats `(type-hints , type hints, type hints )` are used to represent "typehints" across the documentation and docstrings.
This creates confusion ,so this pr aims to standardize all occurences across documentation and docstrings by choosing `typehints` as the default format and replacing all the other formats with this.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ayushthe1 commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
ayushthe1 commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1305978217
Sure @TheNeuralBit ,
> I'm going to propose we switch to "type hints" in documentation. I'll raise on dev@ to see if there are any objections. Can we hold on this for a couple of days?
Sure @TheNeuralBit ,i will make the changes once you confirm them. :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1341082594
.waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304288154
# [Codecov](https://codecov.io/gh/apache/beam/pull/23984?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23984](https://codecov.io/gh/apache/beam/pull/23984?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be6b86e) into [master](https://codecov.io/gh/apache/beam/commit/16852518861514a56ad1b57113e3815cfcc8533a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1685251) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23984 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 709 709
Lines 95971 95983 +12
=======================================
+ Hits 70491 70506 +15
+ Misses 24163 24160 -3
Partials 1317 1317
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.19% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/23984?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `93.77% <ø> (ø)` | |
| [...ks/python/apache\_beam/coders/coders\_test\_common.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyc190ZXN0X2NvbW1vbi5weQ==) | `98.58% <ø> (ø)` | |
| [sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | `94.95% <ø> (ø)` | |
| [sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=) | `93.67% <ø> (ø)` | |
| [.../apache\_beam/examples/cookbook/group\_with\_coder.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvY29va2Jvb2svZ3JvdXBfd2l0aF9jb2Rlci5weQ==) | `51.16% <ø> (ø)` | |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `92.25% <ø> (ø)` | |
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `82.89% <ø> (ø)` | |
| [...ache\_beam/runners/dataflow/ptransform\_overrides.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9wdHJhbnNmb3JtX292ZXJyaWRlcy5weQ==) | `90.90% <ø> (ø)` | |
| [...python/apache\_beam/runners/direct/direct\_runner.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X3J1bm5lci5weQ==) | `93.92% <ø> (ø)` | |
| [...ks/python/apache\_beam/runners/interactive/utils.py](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91dGlscy5weQ==) | `95.08% <ø> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/beam/pull/23984/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1315354776
Hi, I think based on the discussion the Beam dev list(https://lists.apache.org/list?dev@beam.apache.org:lte=1M:typehint)
`type hints` should be the standardized format. Can you change this to `type hints` wherever its possible?
Thanks for the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304206732
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
R: @apilloud for label java.
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ayushthe1 commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
ayushthe1 commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1345616300
> > @TheNeuralBit , any update on this ?
>
> Please look at [#23984 (comment)](https://github.com/apache/beam/pull/23984#issuecomment-1315354776)
Thanks ,i will do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1324968391
Reminder, please take a look at this pr: @AnandInguva @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304259553
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1438422427
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1305994373
Thanks! How about if we don't hear any objection by Wednesday (9 November) we go ahead with switching to "type hints"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304848967
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1305644982
I think we may want to standardize on "type hint" in documentation and "typehint" for code. For reference: [PEP 484](https://peps.python.org/pep-0484/) uses "type hint".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1336147434
Reminder, please take a look at this pr: @pabloem @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1363219035
@ayushthe1 friendly ping:). Any update on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1357690082
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1362769042
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
R: @johnjcasey for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ayushthe1 commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
ayushthe1 commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1345531602
@TheNeuralBit , any update on this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1336174831
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304125576
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
R: @apilloud for label java.
R: @ahmedabu98 for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1340880554
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn for label python.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1357579526
Reminder, please take a look at this pr: @tvalentyn @chamikaramj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1341083221
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1362984438
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1303976448
Thanks for the fix. There is a test failure about assertion to error message:
```
self = <apache_beam.typehints.typehints_test.KVHintTestCase testMethod=test_getitem_param_must_be_tuple>
def test_getitem_param_must_be_tuple(self):
with self.assertRaises(TypeError) as e:
typehints.KV[4]
> self.assertEqual(
'Parameter to KV type-hint must be a tuple of types: '
'KV[.., ..].',
e.exception.args[0])
E AssertionError: 'Parameter to KV type-hint must be a tuple of types: KV[.., ..].' != 'Parameter to KV typehint must be a tuple of types: KV[.., ..].'
E - Parameter to KV type-hint must be a tuple of types: KV[.., ..].
E ? -
E + Parameter to KV typehint must be a tuple of types: KV[.., ..].
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ayushthe1 commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
ayushthe1 commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304545036
thanks @Abacn ,i fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1315228298
Reminder, please take a look at this pr: @AnandInguva @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1580738813
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1345610091
> @TheNeuralBit , any update on this ?
>
>
Please look at https://github.com/apache/beam/pull/23984#issuecomment-1315354776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1327402032
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @pabloem for label python.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1305655986
I'm going to propose we switch to "type hints" in documentation. I'll raise on dev@ to see if there are any objections. Can we hold on this for a couple of days?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ayushthe1 commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by GitBox <gi...@apache.org>.
ayushthe1 commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1304542307
R: @TheNeuralBit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23984:
URL: https://github.com/apache/beam/pull/23984#issuecomment-1592971579
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] closed pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #23984: [Task]: Standardize `typehint` in Python documention and docstrings
URL: https://github.com/apache/beam/pull/23984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org