You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ivan Mitic (JIRA)" <ji...@apache.org> on 2012/10/24 20:50:12 UTC
[jira] [Created] (HADOOP-8972) Move winutils tests from bat to Java
Ivan Mitic created HADOOP-8972:
----------------------------------
Summary: Move winutils tests from bat to Java
Key: HADOOP-8972
URL: https://issues.apache.org/jira/browse/HADOOP-8972
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 1-win
Reporter: Ivan Mitic
Assignee: Ivan Mitic
This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
2. Debugging a test case failure in bat script is not trivial
3. It turned that we are not running the test scripts frequently
Cons:
One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas resolved HADOOP-8972.
-------------------------------------
Resolution: Fixed
Done
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.update.deletefiles.patch, HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483811#comment-13483811 ]
Hadoop QA commented on HADOOP-8972:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12550731/HADOOP-8972.branch-1-win.winutilstests.patch
against trunk revision .
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1673//console
This message is automatically generated.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492014#comment-13492014 ]
Ivan Mitic commented on HADOOP-8972:
------------------------------------
bq. Ivan, I delete src/winutils/tests directory and its content.
Thanks Suresh, deleting src/winutils/tests is what we want.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.update.deletefiles.patch, HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8972) Move winutils tests from bat to Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic updated HADOOP-8972:
-------------------------------
Attachment: HADOOP-8972.branch-1-win.winutilstests.patch
Attaching the patch.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Chuan Liu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489810#comment-13489810 ]
Chuan Liu commented on HADOOP-8972:
-----------------------------------
+1 Change looks good.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8972) Move winutils tests from bat to Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic updated HADOOP-8972:
-------------------------------
Attachment: HADOOP-8972.branch-1-win.update.deletefiles.patch
Attaching the patch that deletes files that are no longer needed.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.update.deletefiles.patch, HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496759#comment-13496759 ]
Ivan Mitic commented on HADOOP-8972:
------------------------------------
Suresh, should we resolve this Jira?
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.update.deletefiles.patch, HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483812#comment-13483812 ]
Ivan Mitic commented on HADOOP-8972:
------------------------------------
Just noticed that this change is incompatible with HADOOP-8874. Specifically, the following code from TestWinUtils.java:
{code}
File winutilsFile = new File(Shell.WINUTILS + ".exe");
File aExe = new File(TEST_DIR, "a.exe");
Shell.execCommand("cmd", "/c", "copy", winutilsFile.getCanonicalPath(),
aExe.getCanonicalPath());
{code}
will have to be updated to the following (notice that there are no ".exe" anymore):
{code}
File winutilsFile = new File(Shell.WINUTILS);
File aExe = new File(TEST_DIR, "a.exe");
Shell.execCommand("cmd", "/c", "copy", winutilsFile.getCanonicalPath(),
aExe.getCanonicalPath());
{code}
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491997#comment-13491997 ]
Suresh Srinivas commented on HADOOP-8972:
-----------------------------------------
Ivan, I delete src/winutils/tests directory and its content.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.update.deletefiles.patch, HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8972) Move winutils tests from bat to Java
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8972:
------------------------------------
Resolution: Fixed
Fix Version/s: 1-win
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
+1 for the patch.
Thank you Ivan. Thank you Chuan for the review. I committed it to branch-1-win.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic reopened HADOOP-8972:
--------------------------------
I missed to delete some files with the original patch, reactivating.
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8972) Move winutils tests from bat to Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Mitic updated HADOOP-8972:
-------------------------------
Status: Patch Available (was: Open)
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8972) Move winutils tests from bat to
Java
Posted by "Ivan Mitic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496801#comment-13496801 ]
Ivan Mitic commented on HADOOP-8972:
------------------------------------
Thanks, wasn't sure if there is something else needed besides resolving the Jira :)
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Fix For: 1-win
>
> Attachments: HADOOP-8972.branch-1-win.update.deletefiles.patch, HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However, in the context of Hadoop this is not an issue so we decided to go with something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira