You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/08/24 21:14:01 UTC
[jira] [Reopened] (HBASE-17249) Get/Scan's
setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as
the parameter instead of creating a new setColumnFamilyTimeRange instance
[ https://issues.apache.org/jira/browse/HBASE-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reopened HBASE-17249:
---------------------------
Reopening. The changes made here contend with another long-standing wish over in HBASE-15284 where we want to NOT let users create TimeRanges explicitly.
[~huaxiang] were you just code-reading?
We need to clean up what our intent for TimeRange is. Opening this in meantime. Related issue is HBASE-15284. Thanks.
> Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-17249
> URL: https://issues.apache.org/jira/browse/HBASE-17249
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: huaxiang sun
> Assignee: huaxiang sun
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-17249-master-001.patch, HBASE-17249-master-002.patch, HBASE-17249-master-003.patch
>
>
> Going through the code, found For Get/Scan's setTimeRange/setColumnFamilyTimeRange, it can use TimeRange as reference instead of creating a new one.
> Reference:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506
> We can implement this in a similar way as filter:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510
> I checked it is same with branch-1.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)