[GitHub] FabianTe commented on a change in pull request #624: Add missing log to Java version check

[GitBox <gi...@apache.org>]

FabianTe commented on a change in pull request #624: Add missing log to Java version check
URL: https://github.com/apache/cordova-android/pull/624#discussion_r251191468
 
 

 ##########
 File path: bin/templates/cordova/lib/check_reqs.js
 ##########
 @@ -355,15 +355,16 @@ module.exports.check_android_target = function (originalError) {
 // Returns a promise.
 module.exports.run = function () {
     return Q.all([this.check_java(), this.check_android()]).then(function (values) {
-        console.log('ANDROID_HOME=' + process.env['ANDROID_HOME']);
-        console.log('JAVA_HOME=' + process.env['JAVA_HOME']);
+        console.log('Checking Java JDK and Android SDK versions');
 
         if (!String(values[0]).startsWith('1.8.')) {
-            throw new CordovaError(`Requirements check failed for JDK 8 ('1.8.*')`);
+            throw new CordovaError(
+              `Requirements check failed for JDK 8 ('1.8.*')! Detected version: ${values[0]}\nCheck your JAVA_HOME / PATH environment variables.`
 
 Review comment:
   The eslint error is now fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org