You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/25 12:09:38 UTC
[GitHub] [camel] orpiske opened a new pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
orpiske opened a new pull request #4296:
URL: https://github.com/apache/camel/pull/4296
This ensures that stacktraces are always handled by the logging
mechanism. Basically replaces all instances of calls to
printStackTrace() with a call to the logger handler.
I put the list of affected components in the ticket. A bit large patch, but in general the patch is simple: it just adds the calls to the logger and adds a logger to the class if needed.
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4296:
URL: https://github.com/apache/camel/pull/4296#issuecomment-698899690
Looking at the failures ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4296:
URL: https://github.com/apache/camel/pull/4296#issuecomment-699068198
> @orpiske can you fix the conflict and merge to master.
Yes I can! I'll do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4296:
URL: https://github.com/apache/camel/pull/4296#issuecomment-699070974
@davsclaus done. The changes from this PR were not necessary anymore on that conflicting file. I will wait for the check to run one more time - for good measure - and will merge it after it passes. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4296:
URL: https://github.com/apache/camel/pull/4296#issuecomment-699067550
@orpiske can you fix the conflict and merge to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske merged pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
Posted by GitBox <gi...@apache.org>.
orpiske merged pull request #4296:
URL: https://github.com/apache/camel/pull/4296
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #4296: CAMEL-15575: prevent stack traces from being printed directly to stdout
Posted by GitBox <gi...@apache.org>.
orpiske commented on pull request #4296:
URL: https://github.com/apache/camel/pull/4296#issuecomment-698899690
Looking at the failures ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org