You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2024/06/18 20:37:54 UTC
[PR] fix: Fix Meson include directories [arrow-nanoarrow]
WillAyd opened a new pull request, #532:
URL: https://github.com/apache/arrow-nanoarrow/pull/532
Quick follow up to https://github.com/apache/arrow-nanoarrow/pull/508 - the array.c includes stopped working without this
```
FAILED: libnanoarrow.so.p/src_nanoarrow_array.c.o
ccache cc -Ilibnanoarrow.so.p -I. -I.. -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c99 -O0 -g -fPIC -MD -MQ libnanoarrow.so.p/src_nanoarrow_array.c.o -MF libnanoarrow.so.p/src_nanoarrow_array.c.o.d -o libnanoarrow.so.p/src_nanoarrow_array.c.o -c ../src/nanoarrow/array.c
../src/nanoarrow/array.c:23:10: fatal error: nanoarrow/nanoarrow.h: No such file or directory
23 | #include "nanoarrow/nanoarrow.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Fix Meson include directories [arrow-nanoarrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #532:
URL: https://github.com/apache/arrow-nanoarrow/pull/532#discussion_r1645052230
##########
meson.build:
##########
@@ -62,18 +38,20 @@ else
libtype = 'library'
endif
+subdir('src')
Review Comment:
I'm a little less sure on the best way to make this work, but the ultimate problem I'm trying to solve is that when using nanoarrow as a subproject you end up with:
```sh
../subprojects/nanoarrow/src/nanoarrow/nanoarrow_types.h:24:10: fatal error: nanoarrow_config.h: No such file or directory
24 | #include "nanoarrow_config.h"
| ^~~~~~~~~~~~~~~~~~~~
```
The CMake file configuration allows you to write directly to the source which is why that relative import works better. For Meson, we would have to either generate this header in `src/nanoarrow` and have the dependency include that path or generate in `src` as is done here, which the dependency already resolves includes to for supporting things like `#include nanoarrow/<>.h`
Another approach would be to change the include to `#include <nanoarrow/nanoarrow_config.h>` in nanoarrow_types.h and generate the configuration file in `src/nanoarrow`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Fix Meson include directories [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #532:
URL: https://github.com/apache/arrow-nanoarrow/pull/532#discussion_r1645208963
##########
meson.build:
##########
@@ -62,18 +38,20 @@ else
libtype = 'library'
endif
+subdir('src')
Review Comment:
> Another approach would be to change the include to `#include <nanoarrow/nanoarrow_config.h>` in `nanoarrow_types.h` and generate the configuration file in `src/nanoarrow`
I think that `#include <nanoarrow/nanoarrow_config.h>` is probably what I intended (but forgot to change!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Fix Meson include directories [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #532:
URL: https://github.com/apache/arrow-nanoarrow/pull/532#discussion_r1645270591
##########
src/nanoarrow/nanoarrow_types.h:
##########
@@ -21,7 +21,7 @@
#include <stdint.h>
#include <string.h>
-#include "nanoarrow_config.h"
+#include <nanoarrow/nanoarrow_config.h>
Review Comment:
```suggestion
#include "nanoarrow/nanoarrow_config.h"
```
(Perhaps less correct, but more consistent with all the other places we currently do this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org