You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dblotsky <gi...@git.apache.org> on 2015/03/07 02:56:47 UTC
[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/121
Copy Mobilespec App Template Instead of Linking It
Instead of symlinking the mobilespec app template when calling `createmobilespec`, copy the template's contents instead. Justifications for this are:
- if files are changed in the created `mobilespec` app, they should not change the template
- symlinking doesn't offer an advantage during development since re-running `createmobilespec` is required anyway when plugins are changed
- on windows symlinks require Administrator privileges
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-mobile-spec copy-on-create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-mobile-spec/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit b632f2c8dad42342b6930823c23afb54f0670bac
Author: Dmitry Blotsky <db...@microsoft.com>
Date: 2015-03-07T01:51:09Z
Using --copy-from instead of --link-to.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-77669959
LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78015632
The idea LGTM, but i would prefer not to remove linking of www at all, just hide it behind a corresponding option (`--linkwww` for example). There is already the same login for plugins and platforms [here](https://github.com/MSOpenTech/cordova-mobile-spec/blob/copy-on-create/createmobilespec/createmobilespec.js#L122).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78153037
I put the change behind a flag called `--copywww`. By default `www` is linked, and if the flag is passed, then it is copied instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org