You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/28 06:59:14 UTC
[GitHub] [flink] leonardBang opened a new pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
leonardBang opened a new pull request #14787:
URL: https://github.com/apache/flink/pull/14787
## What is the purpose of the change
* This pull request aims to fix Blink planner does not ingest the row time timestamp into `StreamRecord` when leaving Table/SQL
## Brief change log
- Improve the `OperatorCodeGenerator` for sink operator to deal the row time properly
## Verifying this change
Add `TableToDataStreamITCase` to check the conversions between `Table` and `DataStream`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14787:
URL: https://github.com/apache/flink/pull/14787#issuecomment-768845020
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60 (Thu Jan 28 07:01:11 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #14787:
URL: https://github.com/apache/flink/pull/14787#discussion_r568366374
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -193,4 +199,18 @@ public CommonExecLegacySink(
inputTransform.getParallelism());
}
}
+
+ private int getRowtimeIndex(RowType inputRowType) {
+ int rowtimeIndex = -1;
+ final List<Integer> rowtimeFieldIndices = new ArrayList<>();
+ for (int i = 0; i < inputRowType.getFieldCount(); ++i) {
+ if (TypeCheckUtils.isRowTime(inputRowType.getTypeAt(i))) {
+ rowtimeFieldIndices.add(i);
+ }
+ }
+ if (rowtimeFieldIndices.size() == 1) {
+ rowtimeIndex = rowtimeFieldIndices.get(0);
Review comment:
How to handle if there are multiple fields with row time attribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14787:
URL: https://github.com/apache/flink/pull/14787#issuecomment-768849685
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12585",
"triggerID" : "43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12585)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #14787:
URL: https://github.com/apache/flink/pull/14787#discussion_r568541945
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -193,4 +199,18 @@ public CommonExecLegacySink(
inputTransform.getParallelism());
}
}
+
+ private int getRowtimeIndex(RowType inputRowType) {
+ int rowtimeIndex = -1;
+ final List<Integer> rowtimeFieldIndices = new ArrayList<>();
+ for (int i = 0; i < inputRowType.getFieldCount(); ++i) {
+ if (TypeCheckUtils.isRowTime(inputRowType.getTypeAt(i))) {
+ rowtimeFieldIndices.add(i);
+ }
+ }
+ if (rowtimeFieldIndices.size() == 1) {
+ rowtimeIndex = rowtimeFieldIndices.get(0);
Review comment:
I think we can skip this just like other places deal the multiple fields with row time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14787:
URL: https://github.com/apache/flink/pull/14787#issuecomment-768849685
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on a change in pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on a change in pull request #14787:
URL: https://github.com/apache/flink/pull/14787#discussion_r568366374
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -193,4 +199,18 @@ public CommonExecLegacySink(
inputTransform.getParallelism());
}
}
+
+ private int getRowtimeIndex(RowType inputRowType) {
+ int rowtimeIndex = -1;
+ final List<Integer> rowtimeFieldIndices = new ArrayList<>();
+ for (int i = 0; i < inputRowType.getFieldCount(); ++i) {
+ if (TypeCheckUtils.isRowTime(inputRowType.getTypeAt(i))) {
+ rowtimeFieldIndices.add(i);
+ }
+ }
+ if (rowtimeFieldIndices.size() == 1) {
+ rowtimeIndex = rowtimeFieldIndices.get(0);
Review comment:
How to handle if there are multiple fields with row time attribute?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #14787:
URL: https://github.com/apache/flink/pull/14787
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14787:
URL: https://github.com/apache/flink/pull/14787#issuecomment-768849685
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12585",
"triggerID" : "43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43d7e4e3c23451fd7cf18cfaa7ba91d8ee47bd60 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12585)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] leonardBang commented on a change in pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner
Posted by GitBox <gi...@apache.org>.
leonardBang commented on a change in pull request #14787:
URL: https://github.com/apache/flink/pull/14787#discussion_r568541945
##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -193,4 +199,18 @@ public CommonExecLegacySink(
inputTransform.getParallelism());
}
}
+
+ private int getRowtimeIndex(RowType inputRowType) {
+ int rowtimeIndex = -1;
+ final List<Integer> rowtimeFieldIndices = new ArrayList<>();
+ for (int i = 0; i < inputRowType.getFieldCount(); ++i) {
+ if (TypeCheckUtils.isRowTime(inputRowType.getTypeAt(i))) {
+ rowtimeFieldIndices.add(i);
+ }
+ }
+ if (rowtimeFieldIndices.size() == 1) {
+ rowtimeIndex = rowtimeFieldIndices.get(0);
Review comment:
I think we can skip this just like other places deal the multiple fields with row time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org