You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/06/17 20:53:01 UTC
[PR] Impreve Dag run and Task Instance notes [airflow]
jscheffl opened a new pull request, #51859:
URL: https://github.com/apache/airflow/pull/51859
Follow-up of #51764
As @pierrejeambrun and @bbovenzi had some feedback, this adds an accordion and limits the maximum space used, add an option to hide notes.
Better like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on code in PR #51859:
URL: https://github.com/apache/airflow/pull/51859#discussion_r2154854413
##########
airflow-core/src/airflow/ui/src/components/EditableMarkdownNotes.tsx:
##########
@@ -0,0 +1,53 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import EditableMarkdownArea from "./EditableMarkdownArea";
+import { Accordion } from "./ui/Accordion";
+
+const EditableMarkdownNotes = ({
Review Comment:
I don't think the name of the component is super descriptive. (vs `EditableMarkdownArea`)
Because it leaves us with `Area` vs `Notes`, impossible to guess who is collapsible, who's not, what's the difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed pull request #51859: Improve Dag run and Task Instance notes
URL: https://github.com/apache/airflow/pull/51859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #51859:
URL: https://github.com/apache/airflow/pull/51859#issuecomment-3217497909
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #51859:
URL: https://github.com/apache/airflow/pull/51859#issuecomment-2985311259
Yeah, thanks for the feedback. Feel free to pull it down and experiment with it. I am not sure where but certain there mgiht be ready-made components in the React ecosystem which would allow an expansion on demand besides the accordion. So I think both commeonts from you are valid and just wanted to signal that I am okay to improve... just my React skills ight be limited to the level like in this PR :-D Yeah and of course we can also leave the maxHeight to a static limit as an increment...
I assume the example with the images is theoretically possible but a very rare/extreme case. Usually I'd expect a few words or notes and as the field is limited to 1000 chars... ~300px might be a realistic size and scrollbars might be also sufficient not to make it overly complex.
So yeah, constructive ideas welcome, no pressure but would be good to make it "pretty" before 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #51859:
URL: https://github.com/apache/airflow/pull/51859#issuecomment-3224872193
Closing in favor of https://github.com/apache/airflow/pull/54163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #51859:
URL: https://github.com/apache/airflow/pull/51859#issuecomment-2984482414
This is better. I still don't like the Tabs moving up and down. I might pull your branch down and play around with the UX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve Dag run and Task Instance notes [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #51859:
URL: https://github.com/apache/airflow/pull/51859#issuecomment-3052090902
This creates an issue with cache invalidation. (Clearing a task with a note, should be reflected directly in the component, but because of the local state, it keeps the old value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org