You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/07/30 12:52:27 UTC
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/2582
[CARBONDATA-2801]Added documentation for flat folder
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata flat-folder-delete-merge
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2582.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2582
----
commit 2e07b434c5b82275e143fb87f05a4ef39b292ae8
Author: ravipesala <ra...@...>
Date: 2018-07-30T12:45:32Z
Added documentation for flat folder
----
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2582
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7663/
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2582
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6065/
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2582
LGTM
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2582
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6079/
---
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2582#discussion_r206413320
--- Diff: docs/data-management-on-carbondata.md ---
@@ -284,6 +286,20 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
+ - **Support Flat folder**
+
+ This feature allows all carbondata and carbonindex files to keep directy under tablepath. Currently all carbondata/carbonindex files written under tablepath/Fact/Part0/Segment_NUM folder and it is not same as hive/parquet folder structure. This feature makes all files written will be directly under tablepath, it does not maintain any segment folder structure.
--- End diff --
rephase to `This feature allows all data files and index files to keep directy under tablepath`
---
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2582
---
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2582#discussion_r206426876
--- Diff: docs/data-management-on-carbondata.md ---
@@ -284,6 +286,20 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
+ - **Support Flat folder**
+
+ This feature allows all carbondata and carbonindex files to keep directy under tablepath. Currently all carbondata/carbonindex files written under tablepath/Fact/Part0/Segment_NUM folder and it is not same as hive/parquet folder structure. This feature makes all files written will be directly under tablepath, it does not maintain any segment folder structure.
--- End diff --
ok
---
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2582#discussion_r206487262
--- Diff: docs/data-management-on-carbondata.md ---
@@ -284,6 +286,20 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
+ - **Support Flat folder**
--- End diff --
change to :
**Support Flat folder same as Hive/Parquet**
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2582
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7622/
---
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2582#discussion_r206496748
--- Diff: docs/data-management-on-carbondata.md ---
@@ -284,6 +286,20 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
+ - **Support Flat folder**
--- End diff --
ok
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2582
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6399/
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2582
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6354/
---
[GitHub] carbondata pull request #2582: [CARBONDATA-2801]Added documentation for flat...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2582#discussion_r206413534
--- Diff: docs/data-management-on-carbondata.md ---
@@ -284,6 +286,20 @@ This tutorial is going to introduce all commands and data operations on CarbonDa
ALTER TABLE employee SET TBLPROPERTIES (‘CACHE_LEVEL’=’Blocklet’)
```
+ - **Support Flat folder**
+
+ This feature allows all carbondata and carbonindex files to keep directy under tablepath. Currently all carbondata/carbonindex files written under tablepath/Fact/Part0/Segment_NUM folder and it is not same as hive/parquet folder structure. This feature makes all files written will be directly under tablepath, it does not maintain any segment folder structure.
--- End diff --
Can you also explain why this is needed, or what scenario user should consider to use this feature.
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2582
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7678/
---
[GitHub] carbondata issue #2582: [CARBONDATA-2801]Added documentation for flat folder
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2582
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6064/
---