You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ya...@apache.org on 2023/08/18 17:56:27 UTC
[spark] branch branch-3.4 updated: Revert "[SPARK-44813][INFRA] The Jira Python misses our assignee when it searches users again"
This is an automated email from the ASF dual-hosted git repository.
yao pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-3.4 by this push:
new 1cfa0806080 Revert "[SPARK-44813][INFRA] The Jira Python misses our assignee when it searches users again"
1cfa0806080 is described below
commit 1cfa080608058b3743472c4b145124512d84cd43
Author: Kent Yao <ya...@apache.org>
AuthorDate: Sat Aug 19 01:56:07 2023 +0800
Revert "[SPARK-44813][INFRA] The Jira Python misses our assignee when it searches users again"
This reverts commit 3c5e57d886b81808370353781bfce2b2ce20a473.
---
dev/merge_spark_pr.py | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/dev/merge_spark_pr.py b/dev/merge_spark_pr.py
index 65d24ea5b78..250348cf761 100755
--- a/dev/merge_spark_pr.py
+++ b/dev/merge_spark_pr.py
@@ -372,7 +372,7 @@ def choose_jira_assignee(issue, asf_jira):
except BaseException:
# assume it's a user id, and try to assign (might fail, we just prompt again)
assignee = asf_jira.user(raw_assignee)
- assign_issue(issue.key, assignee.name)
+ asf_jira.assign_issue(issue.key, assignee.name)
return assignee
except KeyboardInterrupt:
raise
@@ -381,19 +381,6 @@ def choose_jira_assignee(issue, asf_jira):
print("Error assigning JIRA, try again (or leave blank and fix manually)")
-def assign_issue(client: jira.client.JIRA, issue: int, assignee: str) -> bool:
- """
- Assign an issue to a user, which is a shorthand for jira.client.JIRA.assign_issue.
- The original one has an issue that it will search users again and only choose the assignee
- from 20 candidates. If it's unmatched, it picks the head blindly. In our case, the assignee
- is already resolved.
- """
- url = getattr(client, "_get_latest_url")(f"issue/{issue}/assignee")
- payload = {"name": assignee}
- getattr(client, "_session").put(url, data=json.dumps(payload))
- return True
-
-
def resolve_jira_issues(title, merge_branches, comment):
jira_ids = re.findall("SPARK-[0-9]{4,5}", title)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org