[GitHub] [hive] achennagiri commented on a diff in pull request #3487: HIVE-26438: Remove unnecessary optimization in canHandleQbForCbo()

[GitBox <gi...@apache.org>]

achennagiri commented on code in PR #3487:
URL: https://github.com/apache/hive/pull/3487#discussion_r934940068


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java:
##########
@@ -974,44 +972,40 @@ Pair<Boolean, String> canCBOHandleAst(ASTNode ast, QB qb, PreCboCtx cboCtx) {
    *         Query<br>
    *         2. Nested Subquery will return false for qbToChk.getIsQuery()
    */
-  private static String canHandleQbForCbo(QueryProperties queryProperties, HiveConf conf,
-      boolean topLevelQB, boolean verbose) {
-
-    if (!queryProperties.hasClusterBy() && !queryProperties.hasDistributeBy()
-        && !(queryProperties.hasSortBy() && queryProperties.hasLimit())
-        && !queryProperties.hasPTF() && !queryProperties.usesScript()
-        && queryProperties.isCBOSupportedLateralViews()) {
-      // Ok to run CBO.
-      return null;
-    }
-
+  private static String canHandleQbForCbo(QueryProperties queryProperties,
+                                          HiveConf conf, boolean topLevelQB) {
+    List reasons = new ArrayList();
     // Not ok to run CBO, build error message.
-    String msg = "";
-    if (verbose) {
-      if (queryProperties.hasClusterBy()) {
-        msg += "has cluster by; ";
-      }
-      if (queryProperties.hasDistributeBy()) {
-        msg += "has distribute by; ";
-      }
-      if (queryProperties.hasSortBy() && queryProperties.hasLimit()) {
-        msg += "has sort by with limit; ";
-      }
-      if (queryProperties.hasPTF()) {
-        msg += "has PTF; ";
-      }
-      if (queryProperties.usesScript()) {
-        msg += "uses scripts; ";
-      }
-      if (queryProperties.hasLateralViews()) {
-        msg += "has lateral views; ";
-      }
-      if (msg.isEmpty()) {
-        msg += "has some unspecified limitations; ";
-      }
-      msg = msg.substring(0, msg.length() - 2);
+    String errorMsg = "";
+    if (queryProperties.hasClusterBy()) {
+      errorMsg = "has cluster by";
+      reasons.add(errorMsg);
+    }
+    if (queryProperties.hasDistributeBy()) {
+      errorMsg = "has distribute by";
+      reasons.add(errorMsg);
+    }
+    if (queryProperties.hasSortBy() && queryProperties.hasLimit()) {
+      errorMsg = "has sort by with limit";
+      reasons.add(errorMsg);
+    }
+    if (queryProperties.hasPTF()) {
+      errorMsg = "has PTF";
+      reasons.add(errorMsg);
+    }
+    if (queryProperties.usesScript()) {
+      errorMsg = "uses scripts";
+      reasons.add(errorMsg);
+    }
+    if (queryProperties.hasLateralViews()) {
+      errorMsg = "has lateral views";
+      reasons.add(errorMsg);
+    }
+    if (!queryProperties.isCBOSupportedLateralViews()) {

Review Comment:
   Trying to keep the error messaging the same. If isCBOSupportedLateralViews() returns False, only then the error message will be "has some unspecified limitations".
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org