[jira] [Comment Edited] (CASSANDRA-3578) Multithreaded commitlog

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-3578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13835915#comment-13835915 ] 

Benedict edited comment on CASSANDRA-3578 at 12/1/13 12:30 AM:
---------------------------------------------------------------

On the topic of recycling / size issues, I'd drop the following line from CLSM.recycle(File):

{noformat}
            || file.length() != DatabaseDescriptor.getCommitLogSegmentSize()
{noformat}


was (Author: benedict):
On the topic of recycling / size issues, I'd drop the following line from CLSM.recycle(File):

            || file.length() != DatabaseDescriptor.getCommitLogSegmentSize()


> Multithreaded commitlog
> -----------------------
>
>                 Key: CASSANDRA-3578
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3578
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Benedict
>            Priority: Minor
>              Labels: performance
>         Attachments: 0001-CASSANDRA-3578.patch, ComitlogStress.java, Current-CL.png, Multi-Threded-CL.png, TestEA.java, latency.svg, oprate.svg, parallel_commit_log_2.patch
>
>
> Brian Aker pointed out a while ago that allowing multiple threads to modify the commitlog simultaneously (reserving space for each with a CAS first, the way we do in the SlabAllocator.Region.allocate) can improve performance, since you're not bottlenecking on a single thread to do all the copying and CRC computation.
> Now that we use mmap'd CommitLog segments (CASSANDRA-3411) this becomes doable.
> (moved from CASSANDRA-622, which was getting a bit muddled.)



--
This message was sent by Atlassian JIRA
(v6.1#6144)