You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/10 21:38:37 UTC
[GitHub] [incubator-pinot] shahsank3t opened a new pull request #5684: Cluster Manager UI & Query Console UI revamp
shahsank3t opened a new pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684
## Description
Complete revamp of existing UI containing Cluster Manager & Query Console.
- This PR is against https://github.com/apache/incubator-pinot/issues/5649
- Cluster Manager UI contains a listing of Tenants & Table within, Broker, Controller, Server, Cluster Configuration
- Query Console UI is a complete revamp with Material UI styling.
- This PR removes all the existing pinot-controller's static & webapp and gets replaced with an app developed using React + TypeScript + Material UI and few other 3rd Party libraries and built using webpack.
- Also added a plugin in pinot-controller pom file to build the frontend using node & npm.
**Open items that can be added as part of another PR:**
- SQL Hints in SQL Editor
- Reporting error when SQL Query fails
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657281699
> @mayankshriv this is the first cut. lets get this in and we can add more functionality in the subsequent PR
@kishoreg Yes agree, my comment is more towards the general direction of where we should take it. Also, I take it that cluster manager UI will replace Swagger? Would be good to start a doc/issue to capture all the features we would want cluster manager to have and address them in future PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg edited a comment on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
kishoreg edited a comment on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657276179
@shahsank3t This looks great! I tried this locally and it worked seamlessly. I was also able to bring it up by running quickstart from IDE (though it requires one to build the project from the command line)
query editor has some minor issues. The cursor keeps jumping/moving to the end as I type. This happens when you are trying to edit an existing query. typing new query works fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] shahsank3t commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657235908
`testQuery` Test was failing but we longer have static page for query and so removed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
snleee commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657365620
@shahsank3t I see that you are deleting a lot of js files. I think that the license file needs to be updated accordingly. Can you fix `LICENSE` file? You will see the following lines:
```
MIT License
-----------
pinot-controller/src/main/resources/*/js/lib/codemirror/*
pinot-controller/src/main/resources/*/js/lib/foundation/*
pinot-controller/src/main/resources/*/js/lib/angular*
pinot-controller/src/main/resources/*/js/lib/underscore*
pinot-controller/src/main/resources/*/js/lib/jquery-2.1.3.min.js
pinot-controller/src/main/resources/*/js/lib/beautify.js
pinot-controller/src/main/resources/*/js/lib/handlebars.js
pinot-controller/src/main/resources/*/css/lib/codemirror*
pinot-controller/src/main/resources/*/css/lib/foundation*
pinot-controller/src/main/resources/*/css/lib/normalize.css
BSD 3-Clause
------------
pinot-controller/src/main/resources/*/js/lib/jquery.dataTables.min.js
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] shahsank3t commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-658818846
> * For cluster manager, we should be able to drill down at table level as well (apart from the tenant).
@kishoreg @mayankshriv - Addressed this suggestion and added the Tables details page. Yes, currently showing the JSON object and later on can add incremental updates to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-656918270
A couple suggestions:
* For cluster manager, we should be able to drill down at table level as well (apart from tenant).
* It would be super awesome if the UI provides a way to authenticate for certain operations (such as query, write operations on cluster like schema update etc). Note, we already have ACL support in the code, we just need the UI to pass the credentials.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
kishoreg commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657163403
@mayankshriv this is the first cut. lets get this in and we can add more functionality in the subsequent PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
kishoreg commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657276179
@shahsank3t query editor does not work well. the cursor keeps jumping/moving to the end as I type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] shahsank3t commented on pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684#issuecomment-657507251
@kishoreg
Good Catch. Fixed the SQL code editor cursor issue.
@snleee
Updated the existing LICENSE file with the dependencies & dev-dependencies libraries license info. Please have a look and let me know if need to add any more info. Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] kishoreg merged pull request #5684: Cluster Manager UI & Query Console UI revamp
Posted by GitBox <gi...@apache.org>.
kishoreg merged pull request #5684:
URL: https://github.com/apache/incubator-pinot/pull/5684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org