You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/26 05:39:44 UTC
[GitHub] [skywalking] aderm opened a new pull request #4418: refactor
Metrics class.
aderm opened a new pull request #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4418: refactor Metrics
class.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591261728
Seems facing the github pull issue again. You may need to force push to change the commit id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4418: refactor
Metrics class.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591279244
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=h1) Report
> Merging [#4418](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/fa0b3df3692d5e60d072a2dec4fb6c0a9eafc8b5?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4418 +/- ##
==========================================
+ Coverage 25.42% 25.45% +0.03%
==========================================
Files 1211 1211
Lines 28082 28082
Branches 3869 3866 -3
==========================================
+ Hits 7139 7149 +10
+ Misses 20292 20282 -10
Partials 651 651
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `55.17% <100%> (+10.34%)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=footer). Last update [fa0b3df...5f6915b](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4418: refactor Metrics
class.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591268429
I am not sure what happens in GitHub action, but the CI tasks seem strange to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] aderm commented on issue #4418: refactor Metrics class.
Posted by GitBox <gi...@apache.org>.
aderm commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591265489
> force push to change the commit id
`--force` not work, so change commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4418: refactor Metrics
class.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591279244
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=h1) Report
> Merging [#4418](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/fa0b3df3692d5e60d072a2dec4fb6c0a9eafc8b5?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4418 +/- ##
==========================================
+ Coverage 25.42% 25.42% +<.01%
==========================================
Files 1211 1211
Lines 28082 28082
Branches 3869 3866 -3
==========================================
+ Hits 7139 7141 +2
+ Misses 20292 20289 -3
- Partials 651 652 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...king/oap/server/core/analysis/metrics/Metrics.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `55.17% <100%> (+10.34%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `58.33% <0%> (-1.67%)` | :arrow_down: |
| [...kywalking/oap/server/core/analysis/TimeBucket.java](https://codecov.io/gh/apache/skywalking/pull/4418/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvVGltZUJ1Y2tldC5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=footer). Last update [fa0b3df...1597ab5](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4418: refactor Metrics
class.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services