[jira] [Commented] (DRILL-5356) Refactor Parquet Record Reader

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993617#comment-15993617 ] 

ASF GitHub Bot commented on DRILL-5356:
---------------------------------------

Github user paul-rogers commented on the issue:

    https://github.com/apache/drill/pull/789
  
    Squashed and rebased on master. @parthchandra, Padma would like you to review this in addition to her review.
    
    This PR would be incredibly helpful for the next step in the project to fix memory fragmentation: we will implement code to limit batch size -- kind of like the original intent, but this time it should work. That work will be much easier to do on top of the refactored code than on top of the original code.


> Refactor Parquet Record Reader
> ------------------------------
>
>                 Key: DRILL-5356
>                 URL: https://issues.apache.org/jira/browse/DRILL-5356
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.10.0, 1.11.0
>            Reporter: Paul Rogers
>            Assignee: Paul Rogers
>            Priority: Minor
>             Fix For: 1.11.0
>
>
> The Parquet record reader class is a key part of Drill that has evolved over time to become somewhat hard to follow.
> A number of us are working on Parquet-related tasks and find we have to spend an uncomfortable amount of time trying to understand the code. In particular, this writer needs to figure out how to convince the reader to provide higher-density record batches.
> Rather than continue to decypher the complex code multiple times, this ticket requests to refactor the code to make it functionally identical, but structurally cleaner. The result will be faster time to value when working with this code.
> This is a lower-priority change and will be coordinated with others working on this code base. This ticket is only for the record reader class itself; it does not include the various readers and writers that Parquet uses since another project is actively modifying those classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)