You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2019/08/21 11:47:06 UTC
[kudu-CR] [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14114
to look at the new patch set (#2).
Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method
......................................................................
[util] Add ExtractFloat method to JsonReader and improve ExtractDouble method
ExtractDouble method should not only parse double values, int values
that can be losslessly converted to double should also be parsed.
Though there are already IsLosslessDouble()/IsLosslessFloat() methods
in rapidjson library, the implementation seems have problems.
This patch defined new methods to determine whether a value can be
losslessly converted to a double/float value.
Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b
---
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/jsonreader-test.cc
M src/kudu/util/jsonreader.cc
M src/kudu/util/jsonreader.h
4 files changed, 108 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/14114/2
--
To view, visit http://gerrit.cloudera.org:8080/14114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b
Gerrit-Change-Number: 14114
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)