[GitHub] [jena] kinow commented on a change in pull request #1138: JENA-2226: Update Guava version. Manage with a version property.

[GitBox <gi...@apache.org>]

kinow commented on a change in pull request #1138:
URL: https://github.com/apache/jena/pull/1138#discussion_r771988036



##########
File path: jena-shaded-guava/pom.xml
##########
@@ -47,14 +47,11 @@
     <dependency>
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
-      <!-- Version number specified explicitly and not in jena-project, 
-           as it should only be used here, and further shadowing/bundle/NOTICE
-           consideration might be needed on upgrade. 
-           The shading step takes only the com.google.commons/com.google.thirdparty
-           This is important because Guava itself (at v24 at least) has tools dependencies
-           with various licenses.
+      <!-- Version number specified in parent POM but no dependnecy management there.

Review comment:
       s/dependnecy/dependency




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org