[GitHub] [kafka] dajac commented on a diff in pull request #12870: KAFKA-14367; Add `OffsetFetch` to the new `GroupCoordinator` interface

[GitBox <gi...@apache.org>]

dajac commented on code in PR #12870:
URL: https://github.com/apache/kafka/pull/12870#discussion_r1027741608


##########
core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala:
##########
@@ -150,42 +149,6 @@ class OffsetFetchRequestTest extends BaseRequestTest {
     }
   }
 
-  @Test
-  def testOffsetFetchRequestWithMultipleGroupsWithOneGroupRepeating(): Unit = {

Review Comment:
   I have removed this test because I think that this is wrong. When the same group id is specified multiple times, we should rather throw an invalid request rather than doing this. Thoughts?
   
   This was basically due to the fact that we were using an hash map so the last occurrence of a group won. We don't use the hashmap anymore with the patch. Instead, we return an entry for every group present in the request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org