You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/06/07 06:24:47 UTC

[GitHub] [echarts] Ovilia commented on a diff in pull request #16921: fix(custom): provide generic for itemStyle. close #16775

Ovilia commented on code in PR #16921:
URL: https://github.com/apache/echarts/pull/16921#discussion_r890809114


##########
src/chart/custom/CustomSeries.ts:
##########
@@ -319,7 +319,7 @@ export type CustomSeriesRenderItem = (
     api: CustomSeriesRenderItemAPI
 ) => CustomSeriesRenderItemReturn;
 
-export interface CustomSeriesOption extends
+export interface CustomSeriesOption<CallbackDataParams = never> extends

Review Comment:
   Was this necessary? It seems to work without this line change and `= never` doesn't look a good way to define.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org