You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/09 03:12:47 UTC

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #4364: fix(sonarqube): fix minor issues

warren830 commented on code in PR #4364:
URL: https://github.com/apache/incubator-devlake/pull/4364#discussion_r1100936352


##########
backend/core/models/domainlayer/securitytesting/st_issue_code_blocks.go:
##########
@@ -21,14 +21,13 @@ import "github.com/apache/incubator-devlake/core/models/domainlayer"
 
 type StIssueCodeBlock struct {
 	domainlayer.DomainEntity
-	IssueCodeBlockId string `json:"issueCodeBlockId"`

Review Comment:
   I think this is better to be the same to other entities. we have domain id now, we can delete it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org