You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/04/25 08:36:24 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #40941: [MINOR][BUILD] Correct the error message in `dev/connect-check-protos.py`
zhengruifeng opened a new pull request, #40941:
URL: https://github.com/apache/spark/pull/40941
### What changes were proposed in this pull request?
1, update the error message;
2, remove the TO-DO, since this script is dedicated for `pyspark-connect` only
### Why are the changes needed?
```
(spark_dev) ➜ spark git:(master) ls connector/connect/src/main/protobuf
ls: connector/connect/src/main/protobuf: No such file or directory
```
### Does this PR introduce _any_ user-facing change?
no, dev-only
### How was this patch tested?
existing UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #40941: [MINOR][BUILD] Correct the error message in `dev/connect-check-protos.py`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #40941: [MINOR][BUILD] Correct the error message in `dev/connect-check-protos.py`
URL: https://github.com/apache/spark/pull/40941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #40941: [MINOR][BUILD] Correct the error message in `dev/connect-check-protos.py`
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40941:
URL: https://github.com/apache/spark/pull/40941#issuecomment-1522630835
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org