You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/16 22:03:00 UTC
[jira] [Commented] (KAFKA-5463) Controller incorrectly logs rack
information when new brokers are added
[ https://issues.apache.org/jira/browse/KAFKA-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052436#comment-16052436 ]
ASF GitHub Bot commented on KAFKA-5463:
---------------------------------------
GitHub user jeffchao opened a pull request:
https://github.com/apache/kafka/pull/3358
KAFKA-5463: Controller incorrectly logs rack information when new brokers are added
This change is in response to https://issues.apache.org/jira/browse/KAFKA-5463.
When a new broker is added, the `ControllerChannelManager` doesn't log rack information even if configured.
This happens because `ControllerChannelManager` always instantiates a `Node` using the same constructor whether or not rack-aware is configured and causes some confusion when running with rack-aware replica placement.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heroku/kafka fix-controller-rack-aware-logging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3358.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3358
----
commit 9259e141d3655fe58c6e10b22b442a86b5ab8158
Author: Jeff Chao <je...@me.com>
Date: 2017-06-16T21:46:21Z
Include rack information on UpdateMetadata request.
When a new broker is added, the ControllerChannelManager doesn't log
rack information even if configured.
----
> Controller incorrectly logs rack information when new brokers are added
> -----------------------------------------------------------------------
>
> Key: KAFKA-5463
> URL: https://issues.apache.org/jira/browse/KAFKA-5463
> Project: Kafka
> Issue Type: Bug
> Components: config, controller
> Affects Versions: 0.10.2.0, 0.11.0.0, 0.10.2.1
> Environment: Ubuntu Trusty (14.04.5), Oracle JDK 8
> Reporter: Jeff Chao
> Priority: Minor
>
> When a new broker is added, on an {{UpdateMetadata request}}, rack information won't be present in the state-change log even if configured.
> Example:
> {{pri=TRACE t=Controller-1-to-broker-0-send-thread at=logger Controller 1 epoch 1 received response {error_code=0} for a request sent to broker <ip>:<port> (id: 0 rack: null)}}
> This happens because {{ControllerChannelManager}} always instantiates a {{Node}} using the same constructor whether or not rack-aware is configured. We're happy to contribute a patch since this causes some confusion when running with rack-aware replica placement.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)