You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "chewbranca (via GitHub)" <gi...@apache.org> on 2023/05/06 00:04:20 UTC
[GitHub] [couchdb] chewbranca opened a new pull request, #4577: Remove extra unused variable
chewbranca opened a new pull request, #4577:
URL: https://github.com/apache/couchdb/pull/4577
Quick follow up to https://github.com/apache/couchdb/pull/4483 removing a variable that ended up not being used that is currently causing a compiler warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4577: Remove extra unused variable
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4577:
URL: https://github.com/apache/couchdb/pull/4577#discussion_r1186572982
##########
src/couch_log/src/couch_log_writer_stderr.erl:
##########
@@ -27,7 +27,7 @@ init() ->
terminate(_, _St) ->
ok.
-write(#log_entry{type = Type} = Entry, St) ->
Review Comment:
Is it worth keeping the `#log_entry{} = Entry` in the head?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] rnewson commented on a diff in pull request #4577: Remove extra unused variable
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #4577:
URL: https://github.com/apache/couchdb/pull/4577#discussion_r1186658645
##########
src/couch_log/src/couch_log_writer_stderr.erl:
##########
@@ -27,7 +27,7 @@ init() ->
terminate(_, _St) ->
ok.
-write(#log_entry{type = Type} = Entry, St) ->
Review Comment:
I think we should.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] chewbranca commented on a diff in pull request #4577: Remove extra unused variable
Posted by "chewbranca (via GitHub)" <gi...@apache.org>.
chewbranca commented on code in PR #4577:
URL: https://github.com/apache/couchdb/pull/4577#discussion_r1188967886
##########
src/couch_log/src/couch_log_writer_stderr.erl:
##########
@@ -27,7 +27,7 @@ init() ->
terminate(_, _St) ->
ok.
-write(#log_entry{type = Type} = Entry, St) ->
Review Comment:
Well.. 2a70f6d now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] chewbranca commented on a diff in pull request #4577: Remove extra unused variable
Posted by "chewbranca (via GitHub)" <gi...@apache.org>.
chewbranca commented on code in PR #4577:
URL: https://github.com/apache/couchdb/pull/4577#discussion_r1188967332
##########
src/couch_log/src/couch_log_writer_stderr.erl:
##########
@@ -27,7 +27,7 @@ init() ->
terminate(_, _St) ->
ok.
-write(#log_entry{type = Type} = Entry, St) ->
Review Comment:
Fixed in 9e8bb01.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] chewbranca merged pull request #4577: Remove extra unused variable
Posted by "chewbranca (via GitHub)" <gi...@apache.org>.
chewbranca merged PR #4577:
URL: https://github.com/apache/couchdb/pull/4577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org