You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ct...@apache.org on 2015/01/14 01:22:23 UTC

[3/7] accumulo git commit: ACCUMULO-3451 Add more checkstyle checks

ACCUMULO-3451 Add more checkstyle checks

Check for unused imports and bad @see javadoc annotations (those which
incorrectly use @link also)


Project: http://git-wip-us.apache.org/repos/asf/accumulo/repo
Commit: http://git-wip-us.apache.org/repos/asf/accumulo/commit/87eec6fc
Tree: http://git-wip-us.apache.org/repos/asf/accumulo/tree/87eec6fc
Diff: http://git-wip-us.apache.org/repos/asf/accumulo/diff/87eec6fc

Branch: refs/heads/master
Commit: 87eec6fcbd2750c6a6dfdcddbce8b04ecdb4dc6c
Parents: 7651b77
Author: Christopher Tubbs <ct...@apache.org>
Authored: Tue Jan 13 19:04:14 2015 -0500
Committer: Christopher Tubbs <ct...@apache.org>
Committed: Tue Jan 13 19:07:36 2015 -0500

----------------------------------------------------------------------
 pom.xml | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/accumulo/blob/87eec6fc/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 8b4e7b7..5aff5b5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -744,6 +744,10 @@
                   <property name="format" value="\s+$" />
                   <property name="message" value="Line has trailing whitespace." />
                 </module>
+                <module name="RegexpSinglelineJava">
+                  <property name="format" value="[@]see\s+[{][@]link" />
+                  <property name="message" value="Javadoc @see does not need @link: pick one or the other." />
+                </module>
                 <module name="OuterTypeFilename" />
                 <module name="LineLength">
                   <!-- needs extra, because Eclipse formatter ignores the ending left brace -->
@@ -751,6 +755,9 @@
                   <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
                 </module>
                 <module name="AvoidStarImport" />
+                <module name="UnusedImports">
+                  <property name="processJavadoc" value="true" />
+                </module>
                 <module name="NoLineWrap" />
                 <module name="LeftCurly">
                   <property name="maxLineLength" value="160" />