You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/17 11:12:48 UTC
[GitHub] incubator-brooklyn pull request: License not in awkward places
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/169
License not in awkward places
as discussed on ML, the license in the yaml blueprints makes them awkward to use as examples. similarly (but not yet discussed) having them in *every* html page, since most of these are templates, can result in hundreds of copies of the license in the rendered html. this causes bloat and slow-down at runtime. they are not removed by any optimizer (it does not run on html). the license is in the root `index.html` and so shows up on every page served at runtime; and they are in the JS and CSS (where they do get optimized out).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn license-not-in-awkward-places
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 2b3229d03c60524d1642ccc79f384aecfdd0b431
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-17T08:33:13Z
remove license header from yaml examples, as discussed. these files are more like examples / doc / release recipes, so having the huge header in there makes them difficult to use
commit ef59c8c7923e12e5767d7cfb67b3ea76c2a8b26e
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-17T08:55:45Z
remove license headers from most html files; these are templates and included verbatim resulting in the full license header included many many times e.g. for a table.
the header is still present on the index.html which is used to render every page.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License not in awkward places
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/169#issuecomment-56156353
Good point. The original also does not have the header.
https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License not in awkward places
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/169#issuecomment-58437135
Actually, I don't think I can close it from github!
@ahgittin can you please close this PR (because you created it), assuming you agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License not in awkward places
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License not in awkward places
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/169#discussion_r17776277
--- Diff: software/nosql/src/main/resources/brooklyn/entity/nosql/cassandra/cassandra-2.0.yaml ---
@@ -1,22 +1,4 @@
[#ftl]
-#
-# Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
This isn't one of our yaml blueprints (it's the cassandra config file to be uploaded on install). However, it was copy-pasted (and then templated) from the standard Cassandra install.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License not in awkward places
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/169#issuecomment-58437024
I'm closing this. It has been superseded by https://github.com/apache/incubator-brooklyn/pull/214 (already merged) and by https://github.com/apache/incubator-brooklyn/pull/230.
@ahgittin please ping me and/or extract to a new PR if you think anything else in here needs to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: License not in awkward places
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/169#issuecomment-56055122
+1 to removing the license from the HTML templates. (In terms of bandwidth it shouldn't have been *much* of an issue since it should gzip well!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---