You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/27 10:57:18 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

dongjoon-hyun opened a new pull request #29557:
URL: https://github.com/apache/spark/pull/29557


   ### What changes were proposed in this pull request?
   
   This PR aims to support executor id placeholder in `spark.kubernetes.executor.volumes.persistentVolumeClaim.myname.options.claimName` configuration like the following.
   ```
   --conf spark.kubernetes.executor.volumes.persistentVolumeClaim.spark-local-dir-1.options.claimName=pvc-spark-SPARK_EXECUTOR_ID \
   ```
   
   ### Why are the changes needed?
   
   This is a convenient way to mount corresponding PV to the executor.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, but this is a new feature and there is no regression because users don't use `SPARK_EXECUTOR_ID` in PVC claim name.
   
   
   ### How was this patch tested?
   
   Pass the newly added test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681881916


   **[Test build #127953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127953/testReport)** for PR 29557 at commit [`b5fe711`](https://github.com/apache/spark/commit/b5fe711cd9f8e7486d3b1898952f9c08899332be).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-682046727


   Could you review this please, @holdenk and @dbtsai ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681877294


   **[Test build #127953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127953/testReport)** for PR 29557 at commit [`b5fe711`](https://github.com/apache/spark/commit/b5fe711cd9f8e7486d3b1898952f9c08899332be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-682066315


   Thanks. Sure! I have two related PRs. I'll make a K8s doc PR.
   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29557:
URL: https://github.com/apache/spark/pull/29557


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681882056






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681903204


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32578/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681903227






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681877294


   **[Test build #127953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127953/testReport)** for PR 29557 at commit [`b5fe711`](https://github.com/apache/spark/commit/b5fe711cd9f8e7486d3b1898952f9c08899332be).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681903235






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] holdenk commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-682055062


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] holdenk commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
holdenk commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-682055376


   Maybe consider a follow up to document this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681895819


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32578/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29557: [SPARK-32713][K8S] Support execId placeholder in executor PVC conf

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29557:
URL: https://github.com/apache/spark/pull/29557#issuecomment-681882056






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org