You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "superserious-dev (via GitHub)" <gi...@apache.org> on 2025/08/07 03:58:06 UTC

[PR] Implement `DataType::{Binary, LargeBinary, BinaryView}` => `Variant::Binary` [arrow-rs]

superserious-dev opened a new pull request, #8074:
URL: https://github.com/apache/arrow-rs/pull/8074

   # Which issue does this PR close?
   
   - Closes #8050
   
   # Rationale for this change
   
   Adds Binary, LargeBinary, and BinaryView conversions to the cast_to_variant kernel
   
   # What changes are included in this PR?
   
   - a macro to simplify array type conversions
   - conversion of DataType:::{Binary, LargeBinary, BinaryView}=> Variant::Binary
   
   # Are these changes tested?
   
   Yes, additional unit tests have been added.
   
   # Are there any user-facing changes?
   
   Yes, adds new type conversions to kernel
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement `DataType::{Binary, LargeBinary, BinaryView}` => `Variant::Binary` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8074:
URL: https://github.com/apache/arrow-rs/pull/8074#issuecomment-3164768539

   The clippy failure was fixed in 
   - https://github.com/apache/arrow-rs/pull/8078
   
   So that should be fixed by merging up from main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement `DataType::{Binary, LargeBinary, BinaryView}` => `Variant::Binary` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8074:
URL: https://github.com/apache/arrow-rs/pull/8074


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Implement `DataType::{Binary, LargeBinary, BinaryView}` => `Variant::Binary` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #8074:
URL: https://github.com/apache/arrow-rs/pull/8074#issuecomment-3165027364

   Thanks again @superserious-dev  -- I merged this so that other people working on the other types can reuse your macros


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org