[GitHub] cgivre commented on issue #6610: Add support to Apache Drill

[GitBox <gi...@apache.org>]

cgivre commented on issue #6610: Add support to Apache Drill
URL: https://github.com/apache/incubator-superset/pull/6610#issuecomment-467559461
 
 
   Hi @mistercrunch ,
   I'm a little stuck and wondering if perhaps you could point me in the right direction.  
   I've removed all the static references to `@@@` in the code base, instead calling the function in `db_engine_specs` with the exception of two that I can't seem to figure out. 
   
   They are: superset/assets/src/SqlLab/components/SouthPane.jsx and superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx.
   
   I can't seem to figure out how these functions are populated or called from the Python/Flask side. 
   
   ```
   onTableChange(tableName, schemaName) {
   	    this.props.actions.addTable(this.props.queryEditor, tableName, schemaName);
   	    // Mod for Apache Drill
   	    const cleanTableName = tableName.replace('@@@', '.');
   	    this.props.actions.addTable(this.props.queryEditor, cleanTableName, schemaName);
   	  }
   ```
   
   If you could point me in the right direction there, and show me where in the python code these functions are getting the data, I can wrap this up. 
   Thanks in advance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org