[GitHub] [incubator-pinot] xiangfu0 commented on a change in pull request #6964: fixed GenericRow compare for different _fieldToValueMap size

[GitBox <gi...@apache.org>]

xiangfu0 commented on a change in pull request #6964:
URL: https://github.com/apache/incubator-pinot/pull/6964#discussion_r638345602



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java
##########
@@ -227,26 +227,28 @@ public boolean equals(Object obj) {
   }
 
   private boolean compareMap(Map<String, Object> thisMap, Map<String, Object> thatMap) {
-    if (thisMap.size() == thatMap.size()) {
-      for (String key : thisMap.keySet()) {
-        Object fieldValue = thisMap.get(key);
-        Object thatFieldValue = thatMap.get(key);
-        if (fieldValue == null) {
-          if (thatFieldValue != null) {
-            return false;
-          }
-        } else if (!fieldValue.equals(thatFieldValue)) {
-          if (fieldValue instanceof Map && thatFieldValue instanceof Map) {
-            return compareMap((Map<String, Object>) fieldValue, (Map<String, Object>) thatFieldValue);
-          }
-          if ((fieldValue instanceof byte[]) && (thatFieldValue instanceof byte[])) {
-            return Arrays.equals((byte[]) fieldValue, (byte[]) thatFieldValue);
-          }
-          if (fieldValue.getClass().isArray() && thatFieldValue.getClass().isArray()) {
-            return compareArray((Object[]) fieldValue, (Object[]) thatFieldValue);
-          }
+    if (thisMap.size() != thatMap.size()) {

Review comment:
       nit: shall we do null check first?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org