You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Paul Golick (JIRA)" <tu...@ws.apache.org> on 2007/01/17 18:54:30 UTC

[jira] Created: (TUSCANY-1062) DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters

DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters
-------------------------------------------------------------------------------------------------------------------

                 Key: TUSCANY-1062
                 URL: https://issues.apache.org/jira/browse/TUSCANY-1062
             Project: Tuscany
          Issue Type: Bug
          Components: Java SDO Implementation
    Affects Versions: Java-M2
            Reporter: Paul Golick
             Fix For: Java-M3


When createRootObject is called and a root object has already been created, the SDO 2.1 spec calls for an IllegalStateException but the current implementation replaces the existing root.
Also, when either a type is not provided or when a type cannot be determined from the URI and typeName provided, a NullPointerException is thrown from org.eclipse.emf.ecore.util.EcoreUtil.create() which is not helpful to a user who is not literate in emf utilities:  an exception with a helpful error message should be provided.

Attached are:
a) a jar containing a new test case file for DataGraph (sdo/impl/src/test/java/org/apache/tuscany/sdo/test/DataGraphTestCase.java)
b) a patch that corrects these problems in sdo/impl/src/main/java/org/apache/tuscany/sdo/impl/DataGraphImpl.java

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Closed: (TUSCANY-1062) DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters

Posted by "Paul Golick (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Golick closed TUSCANY-1062.
--------------------------------


> DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-1062
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1062
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Implementation
>    Affects Versions: Java-SCA-M2
>            Reporter: Paul Golick
>             Fix For: Java-SDO-beta1
>
>         Attachments: DataGraphImpl_patch.txt, DataGraphTestCase.jar
>
>
> When createRootObject is called and a root object has already been created, the SDO 2.1 spec calls for an IllegalStateException but the current implementation replaces the existing root.
> Also, when either a type is not provided or when a type cannot be determined from the URI and typeName provided, a NullPointerException is thrown from org.eclipse.emf.ecore.util.EcoreUtil.create() which is not helpful to a user who is not literate in emf utilities:  an exception with a helpful error message should be provided.
> Attached are:
> a) a jar containing a new test case file for DataGraph (sdo/impl/src/test/java/org/apache/tuscany/sdo/test/DataGraphTestCase.java)
> b) a patch that corrects these problems in sdo/impl/src/main/java/org/apache/tuscany/sdo/impl/DataGraphImpl.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1062) DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters

Posted by "Paul Golick (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Golick updated TUSCANY-1062:
---------------------------------

    Attachment: DataGraphTestCase.jar
                DataGraphImpl_patch.txt

> DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-1062
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1062
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Implementation
>    Affects Versions: Java-M2
>            Reporter: Paul Golick
>             Fix For: Java-M3
>
>         Attachments: DataGraphImpl_patch.txt, DataGraphTestCase.jar
>
>
> When createRootObject is called and a root object has already been created, the SDO 2.1 spec calls for an IllegalStateException but the current implementation replaces the existing root.
> Also, when either a type is not provided or when a type cannot be determined from the URI and typeName provided, a NullPointerException is thrown from org.eclipse.emf.ecore.util.EcoreUtil.create() which is not helpful to a user who is not literate in emf utilities:  an exception with a helpful error message should be provided.
> Attached are:
> a) a jar containing a new test case file for DataGraph (sdo/impl/src/test/java/org/apache/tuscany/sdo/test/DataGraphTestCase.java)
> b) a patch that corrects these problems in sdo/impl/src/main/java/org/apache/tuscany/sdo/impl/DataGraphImpl.java

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Updated: (TUSCANY-1062) DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters

Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kelvin Goodson updated TUSCANY-1062:
------------------------------------

    Fix Version/s:     (was: Java-SDO-Mx)
                   Java-SDO-M3

> DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-1062
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1062
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Implementation
>    Affects Versions: Java-M2
>            Reporter: Paul Golick
>             Fix For: Java-SDO-M3
>
>         Attachments: DataGraphImpl_patch.txt, DataGraphTestCase.jar
>
>
> When createRootObject is called and a root object has already been created, the SDO 2.1 spec calls for an IllegalStateException but the current implementation replaces the existing root.
> Also, when either a type is not provided or when a type cannot be determined from the URI and typeName provided, a NullPointerException is thrown from org.eclipse.emf.ecore.util.EcoreUtil.create() which is not helpful to a user who is not literate in emf utilities:  an exception with a helpful error message should be provided.
> Attached are:
> a) a jar containing a new test case file for DataGraph (sdo/impl/src/test/java/org/apache/tuscany/sdo/test/DataGraphTestCase.java)
> b) a patch that corrects these problems in sdo/impl/src/main/java/org/apache/tuscany/sdo/impl/DataGraphImpl.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Commented: (TUSCANY-1062) DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters

Posted by "Paul Golick (JIRA)" <tu...@ws.apache.org>.
    [ https://issues.apache.org/jira/browse/TUSCANY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474556 ] 

Paul Golick commented on TUSCANY-1062:
--------------------------------------

I have verified this issue is fixed in revision 509219.  Please close this issue

> DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-1062
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1062
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Implementation
>    Affects Versions: Java-M2
>            Reporter: Paul Golick
>             Fix For: Java-SDO-Mx
>
>         Attachments: DataGraphImpl_patch.txt, DataGraphTestCase.jar
>
>
> When createRootObject is called and a root object has already been created, the SDO 2.1 spec calls for an IllegalStateException but the current implementation replaces the existing root.
> Also, when either a type is not provided or when a type cannot be determined from the URI and typeName provided, a NullPointerException is thrown from org.eclipse.emf.ecore.util.EcoreUtil.create() which is not helpful to a user who is not literate in emf utilities:  an exception with a helpful error message should be provided.
> Attached are:
> a) a jar containing a new test case file for DataGraph (sdo/impl/src/test/java/org/apache/tuscany/sdo/test/DataGraphTestCase.java)
> b) a patch that corrects these problems in sdo/impl/src/main/java/org/apache/tuscany/sdo/impl/DataGraphImpl.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org


[jira] Resolved: (TUSCANY-1062) DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters

Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
     [ https://issues.apache.org/jira/browse/TUSCANY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kelvin Goodson resolved TUSCANY-1062.
-------------------------------------

    Resolution: Fixed

Applied patch, thanks.

> DataGraph.createRootObject implementation does not match 2.1 spec and also is not helpful when given bad parameters
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: TUSCANY-1062
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1062
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Implementation
>    Affects Versions: Java-M2
>            Reporter: Paul Golick
>             Fix For: Java-SDO-Mx
>
>         Attachments: DataGraphImpl_patch.txt, DataGraphTestCase.jar
>
>
> When createRootObject is called and a root object has already been created, the SDO 2.1 spec calls for an IllegalStateException but the current implementation replaces the existing root.
> Also, when either a type is not provided or when a type cannot be determined from the URI and typeName provided, a NullPointerException is thrown from org.eclipse.emf.ecore.util.EcoreUtil.create() which is not helpful to a user who is not literate in emf utilities:  an exception with a helpful error message should be provided.
> Attached are:
> a) a jar containing a new test case file for DataGraph (sdo/impl/src/test/java/org/apache/tuscany/sdo/test/DataGraphTestCase.java)
> b) a patch that corrects these problems in sdo/impl/src/main/java/org/apache/tuscany/sdo/impl/DataGraphImpl.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org