[jira] [Commented] (HADOOP-11089) change "-tokenCacheFile" option to support non-local FS URIs.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132436#comment-14132436 ] 

Hadoop QA commented on HADOOP-11089:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12668523/HADOOP-11089.000.patch
  against trunk revision a0ad975.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.crypto.random.TestOsSecureRandom

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4710//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4710//console

This message is automatically generated.

> change "-tokenCacheFile" option to support non-local FS URIs.
> -------------------------------------------------------------
>
>                 Key: HADOOP-11089
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11089
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security, util
>    Affects Versions: 2.5.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: HADOOP-11089.000.patch
>
>
> change "-tokenCacheFile" option to support non-local FS URIs.
> The current code in GenericOptionsParser only support local FS URIs, It will be better to support non-local FS URIs. 
> {code}
>     FileSystem localFs = FileSystem.getLocal(conf);
>       Path p = localFs.makeQualified(new Path(fileName));
>       if (!localFs.exists(p)) {
>           throw new FileNotFoundException("File "+fileName+" does not exist.");
>       }
> {code}
> We can change above code to
> {code}
>     FileSystem localFs = FileSystem.getLocal(conf);
>       Path p = localFs.makeQualified(new Path(fileName));
>       if (!p.getFileSystem(conf).exists(p)) {
>           throw new FileNotFoundException("File "+fileName+" does not exist.");
>       }
> {code}
> This issue will depend on MAPREDUCE-6086.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)