You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2013/10/07 13:47:40 UTC

Re: Review Request 13499: [GSoC] Add staticNat support to GRE controller

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13499/#review26726
-----------------------------------------------------------

Ship it!


Ship It!

- Hugo Trippaers


On Aug. 12, 2013, 5:09 p.m., tuna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13499/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:09 p.m.)
> 
> 
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I make a patch for supporting staticNat service to gre controller. The scenario is:
> + use GRE isolation method
> + create a network offering with staticNat,Connectivity (Ovs) and sourceNat,...(VirtualRouter)
> + create a guest network using the above network offering
> + deploy VM, enable staticNat
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2 
>   plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324 
>   plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb 
>   plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a 
>   plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 3824669 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6 
>   plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8 
>   server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 
> 
> Diff: https://reviews.apache.org/r/13499/diff/
> 
> 
> Testing
> -------
> 
> Test done with above scenario. 
> Deploy VMs.
> enable/disable staticNat.
> 
> 
> Thanks,
> 
> tuna
> 
>


Re: Review Request 13499: [GSoC] Add staticNat support to GRE controller

Posted by Hugo Trippaers <ht...@schubergphilis.com>.

> On Oct. 7, 2013, 11:47 a.m., Hugo Trippaers wrote:
> > Ship It!

Applied to the sdnextensions branch


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13499/#review26726
-----------------------------------------------------------


On Aug. 12, 2013, 5:09 p.m., tuna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13499/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2013, 5:09 p.m.)
> 
> 
> Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I make a patch for supporting staticNat service to gre controller. The scenario is:
> + use GRE isolation method
> + create a network offering with staticNat,Connectivity (Ovs) and sourceNat,...(VirtualRouter)
> + create a guest network using the above network offering
> + deploy VM, enable staticNat
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2 
>   plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324 
>   plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb 
>   plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a 
>   plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 3824669 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48 
>   plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6 
>   plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8 
>   server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 
> 
> Diff: https://reviews.apache.org/r/13499/diff/
> 
> 
> Testing
> -------
> 
> Test done with above scenario. 
> Deploy VMs.
> enable/disable staticNat.
> 
> 
> Thanks,
> 
> tuna
> 
>