You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "hackergin (via GitHub)" <gi...@apache.org> on 2023/07/03 03:28:13 UTC
[GitHub] [flink] hackergin opened a new pull request, #22928: [FLINK-32473] Introduce base interfaces for time travel
hackergin opened a new pull request, #22928:
URL: https://github.com/apache/flink/pull/22928
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*Introduce base interfaces for time travel. *
## Brief change log
- Add getTable(ObjectPath, long timestamp) method in Catalog interface.
- Add getSnapshot() method in CatalogBaseTable.
- Introduce TableSnapshot interface for representing the snapshot of the table
## Verifying this change
Just introduce some interface declarations, testing may not be necessary at the moment.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackergin commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "hackergin (via GitHub)" <gi...@apache.org>.
hackergin commented on PR #22928:
URL: https://github.com/apache/flink/pull/22928#issuecomment-1617514752
Thanks @luoyuxia for the suggestion , I update the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #22928:
URL: https://github.com/apache/flink/pull/22928#issuecomment-1619334297
Btw, next time, please name the pr title with the format `[FLINK-xxx][xxx] xxx `.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a diff in pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #22928:
URL: https://github.com/apache/flink/pull/22928#discussion_r1257954899
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/DefaultCatalogTable.java:
##########
@@ -40,15 +40,27 @@ public class DefaultCatalogTable implements CatalogTable {
private final List<String> partitionKeys;
private final Map<String, String> options;
+ private final @Nullable Long snapshot;
Review Comment:
@hackergin please also update `CatalogPropertiesUtil.serializeCatalogTable(this)` otherwise we break the contract that `ResolvedCatalogTable` is fully serializable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #22928:
URL: https://github.com/apache/flink/pull/22928#discussion_r1250315785
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogTable.java:
##########
@@ -120,4 +139,9 @@ default TableKind getTableKind() {
default Map<String, String> toProperties() {
return Collections.emptyMap();
}
+
+ /** Return the snapshot specified for the table. Return Optional.empty() if not specified. */
+ default Optional<TableSnapshot> getSnapshot() {
Review Comment:
Please keep it same as the proposed FLIP.
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java:
##########
@@ -244,6 +244,23 @@ void alterDatabase(String name, CatalogDatabase newDatabase, boolean ignoreIfNot
*/
CatalogBaseTable getTable(ObjectPath tablePath) throws TableNotExistException, CatalogException;
+ /**
+ * Returns a {@link CatalogTable} or {@link CatalogView} identified by the given {@link
Review Comment:
suggestion:
```
Returns a {@link CatalogTable} or {@link CatalogView} at a specific time identified by the given {@link ObjectPath}.
```
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/Catalog.java:
##########
@@ -244,6 +244,24 @@ void alterDatabase(String name, CatalogDatabase newDatabase, boolean ignoreIfNot
*/
CatalogBaseTable getTable(ObjectPath tablePath) throws TableNotExistException, CatalogException;
+ /**
+ * Returns a {@link CatalogTable} or {@link CatalogView} identified by the given {@link
+ * ObjectPath} and Timestamp. The framework will resolve the metadata objects when necessary.
+ *
+ * @param tablePath Path of the table or view
+ * @param timestamp Timestamp of the table snapshot, which is milliseconds since 1970-01-01
+ * 00:00:00 UTC
+ * @return The requested table or view
+ * @throws TableNotExistException if the target does not exist
+ * @throws CatalogException in case of any runtime exception
+ */
+ default CatalogBaseTable getTable(ObjectPath tablePath, long timestamp)
+ throws TableNotExistException, CatalogException {
+ throw new UnsupportedOperationException(
+ String.format(
+ "getTable with snapshot is not implemented for %s.", this.getClass()));
Review Comment:
`getTable with snapshot` => `getTable(ObjectPath, long)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #22928:
URL: https://github.com/apache/flink/pull/22928#discussion_r1250315785
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogTable.java:
##########
@@ -120,4 +139,9 @@ default TableKind getTableKind() {
default Map<String, String> toProperties() {
return Collections.emptyMap();
}
+
+ /** Return the snapshot specified for the table. Return Optional.empty() if not specified. */
+ default Optional<TableSnapshot> getSnapshot() {
Review Comment:
Please keep it same as the proposed FLIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a diff in pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #22928:
URL: https://github.com/apache/flink/pull/22928#discussion_r1257956237
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/DefaultCatalogTable.java:
##########
@@ -40,15 +40,27 @@ public class DefaultCatalogTable implements CatalogTable {
private final List<String> partitionKeys;
private final Map<String, String> options;
+ private final @Nullable Long snapshot;
Review Comment:
CC @luoyuxia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackergin commented on a diff in pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "hackergin (via GitHub)" <gi...@apache.org>.
hackergin commented on code in PR #22928:
URL: https://github.com/apache/flink/pull/22928#discussion_r1259115657
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/DefaultCatalogTable.java:
##########
@@ -40,15 +40,27 @@ public class DefaultCatalogTable implements CatalogTable {
private final List<String> partitionKeys;
private final Map<String, String> options;
+ private final @Nullable Long snapshot;
Review Comment:
I submitted the fix pr. https://github.com/apache/flink/pull/22977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackergin commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "hackergin (via GitHub)" <gi...@apache.org>.
hackergin commented on PR #22928:
URL: https://github.com/apache/flink/pull/22928#issuecomment-1618989013
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] hackergin commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "hackergin (via GitHub)" <gi...@apache.org>.
hackergin commented on PR #22928:
URL: https://github.com/apache/flink/pull/22928#issuecomment-1618122109
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia merged pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #22928:
URL: https://github.com/apache/flink/pull/22928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on code in PR #22928:
URL: https://github.com/apache/flink/pull/22928#discussion_r1258040684
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/DefaultCatalogTable.java:
##########
@@ -40,15 +40,27 @@ public class DefaultCatalogTable implements CatalogTable {
private final List<String> partitionKeys;
private final Map<String, String> options;
+ private final @Nullable Long snapshot;
Review Comment:
Thanks for reminder. We will fix update it in FLINK-32569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22928:
URL: https://github.com/apache/flink/pull/22928#issuecomment-1617183502
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "367dbd15a17ab5cab0d09f456c3d555f4bc5052a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "367dbd15a17ab5cab0d09f456c3d555f4bc5052a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 367dbd15a17ab5cab0d09f456c3d555f4bc5052a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org