You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:41:07 UTC
[GitHub] [trafficserver-ci] traeak opened a new pull request #61: change from docker agent to just controller node
traeak opened a new pull request #61:
URL: https://github.com/apache/trafficserver-ci/pull/61
Changed from running docker agent on the controller to just having the controller do the install.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver-ci] bneradt commented on a change in pull request #61: change from docker agent to just controller node
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #61:
URL: https://github.com/apache/trafficserver-ci/pull/61#discussion_r730018148
##########
File path: jenkins/branch/docs.pipeline
##########
@@ -73,7 +73,7 @@ pipeline {
}
}
post {
- success {
+ always {
Review comment:
Even if the docs build fails we want to publish it? I'm probably misunderstanding what this is doing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver-ci] traeak commented on pull request #61: change from docker agent to just controller node
Posted by GitBox <gi...@apache.org>.
traeak commented on pull request #61:
URL: https://github.com/apache/trafficserver-ci/pull/61#issuecomment-944501127
These are just build artifacts. The docs themselves won't publish unless
the build stage succeeds.
On Fri, Oct 15, 2021, 11:56 Brian Neradt ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In jenkins/branch/docs.pipeline
> <https://github.com/apache/trafficserver-ci/pull/61#discussion_r730018148>
> :
>
> > @@ -73,7 +73,7 @@ pipeline {
> }
> }
> post {
> - success {
> + always {
>
> Even if the docs build fails we want to publish it? I'm probably
> misunderstanding what this is doing...
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/trafficserver-ci/pull/61#pullrequestreview-781102725>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AFSNPDIOGBTZYHLT7MDCAO3UHBTMDANCNFSM5GCISIWA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver-ci] traeak merged pull request #61: change from docker agent to just controller node
Posted by GitBox <gi...@apache.org>.
traeak merged pull request #61:
URL: https://github.com/apache/trafficserver-ci/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org